Skip to content

Commit 2288fff

Browse files
committed
try another way
1 parent 425dcaa commit 2288fff

File tree

3 files changed

+9
-42
lines changed

3 files changed

+9
-42
lines changed

.github/workflows/agent-ci.yaml

Lines changed: 8 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5,31 +5,19 @@ jobs:
55
name: Run tests & display coverage
66
runs-on: ubuntu-latest
77
permissions:
8-
# Gives the action the necessary permissions for publishing new
9-
# comments in pull requests.
8+
contents: read
9+
issues: read
10+
checks: write
1011
pull-requests: write
11-
# Gives the action the necessary permissions for pushing data to the
12-
# python-coverage-comment-action branch, and for editing existing
13-
# comments (to avoid publishing multiple comments in the same PR)
14-
contents: write
1512
steps:
1613
- uses: actions/checkout@v4
17-
1814
- name: Install everything, run the tests, produce the .coverage file
1915
run: |
2016
cd agent
2117
make test
22-
- name: Coverage comment
23-
id: coverage_comment
24-
uses: py-cov-action/python-coverage-comment-action@v3
18+
- name: Publish Test Results
19+
uses: EnricoMi/publish-unit-test-result-action@v2
20+
if: always()
2521
with:
26-
COVERAGE_PATH: agent/
27-
GITHUB_TOKEN: ${{ github.token }}
28-
- name: Store Pull Request comment to be posted
29-
uses: actions/upload-artifact@v4
30-
if: steps.coverage_comment.outputs.COMMENT_FILE_WRITTEN == 'true'
31-
with:
32-
# If you use a different name, update COMMENT_ARTIFACT_NAME accordingly
33-
name: python-coverage-comment-action
34-
# If you use a different name, update COMMENT_FILENAME accordingly
35-
path: python-coverage-comment-action.txt
22+
files: |
23+
agent/coverage.xml

.github/workflows/agent-coverage.yaml

Lines changed: 0 additions & 21 deletions
This file was deleted.

agent/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ venv: ## Sets up a python venv at `./venv`
3434
test: venv ## Test using hatch, prints coverage and outputs a report to coverage.xml
3535
$(VENV)hatch -p skyhook-agent test --cover-quiet
3636
$(VENV)coverage report --show-missing --data-file=skyhook-agent/.coverage
37-
## $(VENV)coverage xml --data-file=skyhook-agent/.coverage
37+
$(VENV)coverage xml --data-file=skyhook-agent/.coverage
3838

3939
.PHONY: format
4040
format:

0 commit comments

Comments
 (0)