Skip to content

Commit f1b8e09

Browse files
committed
feat: update readmes for using ghcr image and update tuning for most recent changes
1 parent a8086fa commit f1b8e09

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

shellscript/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This Skyhook Package allows you to run arbitrary bash scripts defined in your Sk
44
```
55
example:
66
version: 1.0.0
7-
image: nvcr.io/skyhook/shellscript
7+
image: ghcr.io/nvidia/skyhook-packages/shellscript
88
configMap:
99
apply.sh: |-
1010
#!/bin/bash

tuning/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ Specify different interrupts for the configmap interrupts to apply a more limite
3939
```yaml
4040
tuning:
4141
version: 1.0.0
42-
image: nvcr.io/skyhook/tuning:1.0.0
42+
image: ghcr.io/nvidia/skyhook-packages/tuning:1.0.0
4343
interrupt:
4444
type: reboot
4545
configInterrupts:

tuning/skyhook_dir/update_settings_post_check.sh

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ if [ -f ${SKYHOOK_DIR}/configmaps/sysctl.conf ]; then
2424
done <<< $(cat ${SKYHOOK_DIR}/configmaps/sysctl.conf)
2525
fi
2626

27-
if [[ -f ${SKYHOOK_DIR}/configmaps/service_containerd.conf || -f ${SKYHOOK_DIR}/configmaps/service_crio.conf ]]; then
27+
function container_check {
28+
file=$1
2829
echo "-------------------------"
2930
echo "Check container limits"
3031
echo "-------------------------"
@@ -67,7 +68,15 @@ if [[ -f ${SKYHOOK_DIR}/configmaps/service_containerd.conf || -f ${SKYHOOK_DIR}/
6768
failures=$(printf "%s\n%s" "${failures}" "$name: ${expected_value} != ${actual_value}")
6869
fi
6970
# Use cat here instead of < file in case of single line files
70-
done <<< $(cat ${SKYHOOK_DIR}/configmaps/container_limits.conf)
71+
done <<< $(cat $file | grep Limit)
72+
}
73+
74+
if [ -f ${SKYHOOK_DIR}/configmaps/service_containerd.conf ]; then
75+
container_check ${SKYHOOK_DIR}/configmaps/service_containerd.conf
76+
fi
77+
78+
if [ -f ${SKYHOOK_DIR}/configmaps/service_crio.conf ]; then
79+
container_check ${SKYHOOK_DIR}/configmaps/service_crio.conf
7180
fi
7281

7382
if [ -f ${SKYHOOK_DIR}/configmaps/grub.conf ]; then

0 commit comments

Comments
 (0)