Merge pull request #5 from NVIDIA/fix_tuning3

fix(tuning): ulimit check was broken along with readme example

Author: ayuskauskas

tuning/README.md

@@ -38,7 +38,7 @@ Use main reboot interrupt for the first apply.
 Specify different interrupts for the configmap interrupts to apply a more limited one depending on which one changes.
 ```yaml
 tuning:
-    version: 1.0.0
+    version: 1.1.3
     image: ghcr.io/nvidia/skyhook-packages/tuning
     interrupt:
         type: reboot
@@ -60,14 +60,14 @@ tuning:
             vm.max_map_count=262144
             vm.min_free_kbytes=65536
         ulimit.conf: |-
-            memlock: 128
-            fsize: 1000
+            memlock=128
+            fsize=1000
 ```
 
 Update just sysctl
 ```yaml
 tuning:
-    version: 1.0.0
+    version: 1.1.3
     image: ghcr.io/nvidia/skyhook-packages/tuning
     interrupt:
         type: restart_all_services
@@ -83,7 +83,7 @@ tuning:
 Update containerd stack size
 ```yaml
 tuning:
-    version: 1.0.0
+    version: 1.1.3
     image: ghcr.io/nvidia/skyhook-packages/tuning
     interrupt:
         type: service

tuning/skyhook_dir/update_settings_check.sh

@@ -47,7 +47,9 @@ fi
 if [ -f ${SKYHOOK_DIR}/configmaps/ulimit.conf ]; then
     while IFS= read -r line
     do
-        if [ $(grep -c "${line}" /etc/security/limits.d/999-${package_name}-tuning.conf) -eq 0 ]; then
+        name=$(echo $line | cut -f 1 -d =)
+        value=$(echo $line | cut -f 2 -d =)
+        if [ $(grep -c "hard ${name} ${value}" /etc/security/limits.d/999-${package_name}-tuning.conf) -eq 0 ]; then
             failures=$(printf "%s\n%s" "$failures" "No ${line} setting in /etc/security/limits.d/999-${package_name}-tuning.conf")
         fi
     done  <<< $(cat ${SKYHOOK_DIR}/configmaps/ulimit.conf)