Skip to content

🐛[BUG]: Bugs with ElliCylinder class in primitive_3d.py #264

@Karl-JT

Description

@Karl-JT

Version

2.2.0

On which installation method(s) does this occur?

Docker

Describe the issue

In primitive_3d.py from line 1959-1967, the following code provides the bounds for interior_sampling. However the "z" is replaced with "y" in the code and causing errors.

    # calculate bounds
    bounds = Bounds(
        {
            Parameter("x"): (center[0] - a, center[0] + a),
            Parameter("y"): (center[0] - b, center[0] + b),
            Parameter("y"): (center[0] - height / 2, center[0] + height / 2),
        },
        parameterization=parameterization,
    )

Additionally, the ElliCylinder class only allowed for a>b, and it is only specified in a comment in the primitive_3d at line 1669. The customer ran into problem having b>a, but the error message is hard to debug.

Minimum reproducible example

Relevant log output

Environment details

Other/Misc.

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    ? - Needs TriageNeed team to review and classifybugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions