Skip to content

CLI flags should be ignored when an unrecognised hook is detected #1225

@elezar

Description

@elezar

In #1000 we tried to avoid failures for unsupported hooks (to allow some version skew between toolkit versions). This does not work as expected beacaus the flags passed to the unexepected hook cause an error:

$ nvidia-cdi-hook create-soname-symlinks --folder foo
Incorrect Usage: flag provided but not defined: -folder

NAME:
   NVIDIA CDI Hook - Command to structure files for usage inside a container, called as hooks from a container runtime, defined in a CDI yaml file

USAGE:
   NVIDIA CDI Hook [global options] [command [command options]]

VERSION:
   1.18.0-rc.2
commit: 08b3a388e7b1d447e10d4c4d4a71dca29a98a964

COMMANDS:
   update-ldcache                    Update ldcache in a container by running ldconfig
   create-symlinks                   A hook to create symlinks in the container.
   chmod                             Set the permissions of folders in the container by running chmod. The container root is prefixed to the specified paths.
   enable-cuda-compat                This hook ensures that the folder containing the CUDA compat libraries is added to the ldconfig search path if required.
   disable-device-node-modification  Ensure that the /proc/driver/nvidia/params file present in the container does not allow device node modifications.
   help, h                           Shows a list of commands or help for one command

GLOBAL OPTIONS:
   --debug, -d    Enable debug-level logging (default: false) [$NVIDIA_CTK_DEBUG, $NVIDIA_CDI_DEBUG]
   --quiet        Suppress all output except for errors; overrides --debug (default: false) [$NVIDIA_CTK_QUIET, $NVIDIA_CDI_QUIET]
   --help, -h     show help
   --version, -v  print the version
ERRO[0000] flag provided but not defined: -folder

Should give:

$ nvidia-cdi-hook create-soname-symlinks
WARN[0000] Unsupported CDI hook: create-soname-symlinks

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions