Honor NVC_DEBUG_FILE or a -debug flag or similar

[anthonyrisinger]

I'm configuring this wrapper in a k8s cluster environment. The config file is only used to read a debug option; it'd be nice if every tool in the stack (nvidia-container-runtime, nvidia-container-toolkit, libnvidia-container) respected [the same] debug file via environment variable. Ideally, they'd all support -debug (only this binary is missing a debug flag, nvidia-container-toolkit and libnvidia-container both support a flag, the latter supports NVC_DEBUG_FILE too).

[anthonyrisinger]

Similarly, it'd be nice if a -config file could be set (like the toolkit / hook proper), without resorting to XDG_CONFIG_HOME and a wrapper (daemon.json supports runtime arguments); if both the runtime and toolkit binaries supported -debug and -config flags, I would be happy (-config alone is enough, so long as I can configure its location).

[klueska]

Hi @anthonyrisinger. Thank you for sour suggestions.

These are both well known "annoyances" that have NVIDIA internal tickets to address them, but currently haven't been prioritized for fixing yet. It would also help streamline our own wrapping that we do around these components in https://gitlab.com/nvidia/container-toolkit/container-config/-/blob/master/src/toolkit.sh

Over the next few months we are planning on doing a major overhaul of the entire libnvidia-container/ nvidia-container-toolkit/ nvidia-container-runtime / nvidia-docker stack, at which point none of this will be relevant anymore.

That said, I will see what we can do about getting adressing these fairly low-hanging issue in the meantime.

[github-actions]

This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed. To skip these checks, apply the "lifecycle/frozen" label.

[ArangoGutierrez]

The nvidia-ctk now supports NVIDIA_CTK_DEBUG and the --debug flag

the nvidia-container-runtime considers the value of --log and --log-format flags that may be passed to it by a container runtime such as docker or containerd. If the --debug flag is present the log-level specified in the config file is overridden as "debug".

Hope these additions since your post satisfy your ask. I am closing this issue, please feel free to reopen if this is not the case.