Skip to content

Commit fd865bb

Browse files
committed
Disable nvsandboxutils in nvcdi API
Repeated calls to nvsandboxutils.Init and Shutdown are causing segmentation violations. Here we disabled nvsandbox utils unless explicitly specified. Signed-off-by: Evan Lezar <[email protected]>
1 parent 6b037a0 commit fd865bb

File tree

1 file changed

+18
-13
lines changed

1 file changed

+18
-13
lines changed

pkg/nvcdi/lib.go

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -111,19 +111,24 @@ func New(opts ...Option) (Interface, error) {
111111
}
112112
l.nvmllib = nvml.New(nvmlOpts...)
113113
}
114-
if l.nvsandboxutilslib == nil {
115-
var nvsandboxutilsOpts []nvsandboxutils.LibraryOption
116-
// Set the library path for libnvidia-sandboxutils
117-
candidates, err := l.driver.Libraries().Locate("libnvidia-sandboxutils.so.1")
118-
if err != nil {
119-
l.logger.Warningf("Ignoring error in locating libnvidia-sandboxutils.so.1: %v", err)
120-
} else {
121-
libNvidiaSandboxutilsPath := candidates[0]
122-
l.logger.Infof("Using %v", libNvidiaSandboxutilsPath)
123-
nvsandboxutilsOpts = append(nvsandboxutilsOpts, nvsandboxutils.WithLibraryPath(libNvidiaSandboxutilsPath))
124-
}
125-
l.nvsandboxutilslib = nvsandboxutils.New(nvsandboxutilsOpts...)
126-
}
114+
// TODO: Repeated calls to nvsandboxutils.Init and Shutdown are causing
115+
// segmentation violations. Here we disabled nvsandbox utils unless explicitly
116+
// specified.
117+
// This will be reenabled as soon as we have more visibility into why this is
118+
// happening and a mechanism to detect and disable this if required.
119+
// if l.nvsandboxutilslib == nil {
120+
// var nvsandboxutilsOpts []nvsandboxutils.LibraryOption
121+
// // Set the library path for libnvidia-sandboxutils
122+
// candidates, err := l.driver.Libraries().Locate("libnvidia-sandboxutils.so.1")
123+
// if err != nil {
124+
// l.logger.Warningf("Ignoring error in locating libnvidia-sandboxutils.so.1: %v", err)
125+
// } else {
126+
// libNvidiaSandboxutilsPath := candidates[0]
127+
// l.logger.Infof("Using %v", libNvidiaSandboxutilsPath)
128+
// nvsandboxutilsOpts = append(nvsandboxutilsOpts, nvsandboxutils.WithLibraryPath(libNvidiaSandboxutilsPath))
129+
// }
130+
// l.nvsandboxutilslib = nvsandboxutils.New(nvsandboxutilsOpts...)
131+
// }
127132
if l.devicelib == nil {
128133
l.devicelib = device.New(l.nvmllib)
129134
}

0 commit comments

Comments
 (0)