Skip to content

Commit e588bfa

Browse files
committed
Reorder extends for internal pipelines
This change updates the ordering of internal pipeline dependencies to ensure that the correct rules are applied. Signed-off-by: Evan Lezar <[email protected]>
1 parent 2240205 commit e588bfa

File tree

2 files changed

+19
-24
lines changed

2 files changed

+19
-24
lines changed

.common-ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ stages:
3737
.main-or-manual:
3838
rules:
3939
- if: $CI_COMMIT_BRANCH == "main"
40+
- if: $CI_COMMIT_TAG && $CI_COMMIT_TAG != ""
4041
- if: $CI_PIPELINE_SOURCE == "schedule"
4142
when: manual
4243

.nvidia-ci.yml

Lines changed: 18 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -68,29 +68,29 @@ variables:
6868

6969
image-centos7:
7070
extends:
71-
- .image-pull
7271
- .dist-centos7
72+
- .image-pull
7373

7474
image-ubi8:
7575
extends:
76-
- .image-pull
7776
- .dist-ubi8
77+
- .image-pull
7878

7979
image-ubuntu18.04:
8080
extends:
81-
- .image-pull
8281
- .dist-ubuntu18.04
82+
- .image-pull
8383

8484
image-ubuntu20.04:
8585
extends:
86-
- .image-pull
8786
- .dist-ubuntu20.04
87+
- .image-pull
8888

8989
# The DIST=packaging target creates an image containing all built packages
9090
image-packaging:
9191
extends:
92-
- .image-pull
9392
- .dist-packaging
93+
- .image-pull
9494

9595
# We skip the integration tests for the internal CI:
9696
.integration:
@@ -109,7 +109,8 @@ image-packaging:
109109
IMAGE: "${CI_REGISTRY_IMAGE}/container-toolkit:${CI_COMMIT_SHORT_SHA}-${DIST}"
110110
IMAGE_ARCHIVE: "container-toolkit.tar"
111111
rules:
112-
- if: $SKIP_SCANS != "yes"
112+
- if: $SKIP_SCANS != "yes"
113+
- when: manual
113114
before_script:
114115
- docker login -u "${CI_REGISTRY_USER}" -p "${CI_REGISTRY_PASSWORD}" "${CI_REGISTRY}"
115116
# TODO: We should specify the architecture here and scan all architectures
@@ -134,59 +135,59 @@ image-packaging:
134135
# Define the scan targets
135136
scan-centos7-amd64:
136137
extends:
137-
- .scan
138138
- .dist-centos7
139139
- .platform-amd64
140+
- .scan
140141
needs:
141142
- image-centos7
142143

143144
scan-centos7-arm64:
144145
extends:
145-
- .scan
146146
- .dist-centos7
147147
- .platform-arm64
148+
- .scan
148149
needs:
149150
- image-centos7
150151
- scan-centos7-amd64
151152

152153
scan-ubuntu18.04-amd64:
153154
extends:
154-
- .scan
155155
- .dist-ubuntu18.04
156156
- .platform-amd64
157+
- .scan
157158
needs:
158159
- image-ubuntu18.04
159160

160161
scan-ubuntu20.04-amd64:
161162
extends:
162-
- .scan
163163
- .dist-ubuntu20.04
164164
- .platform-amd64
165+
- .scan
165166
needs:
166167
- image-ubuntu20.04
167168

168169
scan-ubuntu20.04-arm64:
169170
extends:
170-
- .scan
171171
- .dist-ubuntu20.04
172172
- .platform-arm64
173+
- .scan
173174
needs:
174175
- image-ubuntu20.04
175176
- scan-ubuntu20.04-amd64
176177

177178
scan-ubi8-amd64:
178179
extends:
179-
- .scan
180180
- .dist-ubi8
181181
- .platform-amd64
182+
- .scan
182183
needs:
183184
- image-ubi8
184185

185186
scan-ubi8-arm64:
186187
extends:
187-
- .scan
188188
- .dist-ubi8
189189
- .platform-arm64
190+
- .scan
190191
needs:
191192
- image-ubi8
192193
- scan-ubi8-amd64
@@ -208,31 +209,24 @@ release:staging-ubuntu18.04:
208209
needs:
209210
- image-ubuntu18.04
210211

211-
release:staging-ubuntu20.04:
212-
extends:
213-
- .release:staging
214-
- .dist-ubuntu20.04
215-
needs:
216-
- image-ubuntu20.04
217-
218212
# Define the external release targets
219213
# Release to NGC
220214
release:ngc-centos7:
221215
extends:
222-
- .release:ngc
223216
- .dist-centos7
217+
- .release:ngc
224218

225219
release:ngc-ubuntu18.04:
226220
extends:
227-
- .release:ngc
228221
- .dist-ubuntu18.04
222+
- .release:ngc
229223

230224
release:ngc-ubuntu20.04:
231225
extends:
232-
- .release:ngc
233226
- .dist-ubuntu20.04
227+
- .release:ngc
234228

235229
release:ngc-ubi8:
236230
extends:
237-
- .release:ngc
238231
- .dist-ubi8
232+
- .release:ngc

0 commit comments

Comments
 (0)