Skip to content

Commit b131397

Browse files
committed
Disable nvsandboxutils in nvcdi API
Repeated calls to nvsandboxutils.Init and Shutdown are causing segmentation violations. Here we disabled nvsandbox utils unless explicitly specified. Signed-off-by: Evan Lezar <[email protected]>
1 parent 65b575f commit b131397

File tree

1 file changed

+18
-13
lines changed

1 file changed

+18
-13
lines changed

pkg/nvcdi/lib.go

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -99,19 +99,24 @@ func New(opts ...Option) (Interface, error) {
9999
}
100100
l.nvmllib = nvml.New(nvmlOpts...)
101101
}
102-
if l.nvsandboxutilslib == nil {
103-
var nvsandboxutilsOpts []nvsandboxutils.LibraryOption
104-
// Set the library path for libnvidia-sandboxutils
105-
candidates, err := l.driver.Libraries().Locate("libnvidia-sandboxutils.so.1")
106-
if err != nil {
107-
l.logger.Warningf("Ignoring error in locating libnvidia-sandboxutils.so.1: %v", err)
108-
} else {
109-
libNvidiaSandboxutilsPath := candidates[0]
110-
l.logger.Infof("Using %v", libNvidiaSandboxutilsPath)
111-
nvsandboxutilsOpts = append(nvsandboxutilsOpts, nvsandboxutils.WithLibraryPath(libNvidiaSandboxutilsPath))
112-
}
113-
l.nvsandboxutilslib = nvsandboxutils.New(nvsandboxutilsOpts...)
114-
}
102+
// TODO: Repeated calls to nvsandboxutils.Init and Shutdown are causing
103+
// segmentation violations. Here we disabled nvsandbox utils unless explicitly
104+
// specified.
105+
// This will be reenabled as soon as we have more visibility into why this is
106+
// happening and a mechanism to detect and disable this if required.
107+
// if l.nvsandboxutilslib == nil {
108+
// var nvsandboxutilsOpts []nvsandboxutils.LibraryOption
109+
// // Set the library path for libnvidia-sandboxutils
110+
// candidates, err := l.driver.Libraries().Locate("libnvidia-sandboxutils.so.1")
111+
// if err != nil {
112+
// l.logger.Warningf("Ignoring error in locating libnvidia-sandboxutils.so.1: %v", err)
113+
// } else {
114+
// libNvidiaSandboxutilsPath := candidates[0]
115+
// l.logger.Infof("Using %v", libNvidiaSandboxutilsPath)
116+
// nvsandboxutilsOpts = append(nvsandboxutilsOpts, nvsandboxutils.WithLibraryPath(libNvidiaSandboxutilsPath))
117+
// }
118+
// l.nvsandboxutilslib = nvsandboxutils.New(nvsandboxutilsOpts...)
119+
// }
115120
if l.devicelib == nil {
116121
l.devicelib = device.New(l.nvmllib)
117122
}

0 commit comments

Comments
 (0)