Correct typo in nvsandboxutils feature flag

This original implementation of the FeatureDisableNvsandboxUtils feature
flag included a dash that was not supposed to be there. This change
updates the feature flag's string representation to disable-nvsandboxutils.

Special handling is included for users that may still use the old string
value (e.g. for the nvidia-ctk cdi generate command), but no changes are
expected for users of the nvcdi API.

Signed-off-by: Evan Lezar <[email protected]>

Author: elezar

pkg/nvcdi/api.go

@@ -80,9 +80,11 @@ const (
 	// FeatureEnableExplicitDriverLibraries enables the inclusion of a list of
 	// explicit driver libraries.
 	FeatureEnableExplicitDriverLibraries = FeatureFlag("enable-explicit-driver-libraries")
+
 	// FeatureDisableNvsandboxUtils disables the use of nvsandboxutils when
 	// querying devices.
-	FeatureDisableNvsandboxUtils = FeatureFlag("disable-nvsandbox-utils")
+	FeatureDisableNvsandboxUtils = FeatureFlag("disable-nvsandboxutils")
+
 	// FeatureEnableCoherentAnnotations enables the addition of annotations
 	// coherent or non-coherent devices.
 	FeatureEnableCoherentAnnotations = FeatureFlag("enable-coherent-annotations")

pkg/nvcdi/options.go

@@ -183,6 +183,11 @@ func WithFeatureFlags[T string | FeatureFlag](featureFlags ...T) Option {
 			o.featureFlags = make(map[FeatureFlag]bool)
 		}
 		for _, featureFlag := range featureFlags {
+			// The initial release of the FeatureDisableNvsandboxUtils feature
+			// flag included a typo which we handle here.
+			if string(featureFlag) == "disable-nvsandbox-utils" {
+				featureFlag = T(FeatureDisableNvsandboxUtils)
+			}
 			o.featureFlags[FeatureFlag(featureFlag)] = true
 		}
 	}