[no-relnote] Add e2e test for symlinks

Signed-off-by: Evan Lezar <[email protected]>

Author: elezar

tests/e2e/nvidia-container-toolkit_test.go

@@ -24,11 +24,14 @@ import (
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+	. "github.com/onsi/gomega/gcustom"
 )
 
 // Integration tests for Docker runtime
 var _ = Describe("docker", Ordered, ContinueOnFailure, func() {
 	var runner Runner
+	var hostDriverVersion string
+	var hostDriverMajor string
 
 	// Install the NVIDIA Container Toolkit
 	BeforeAll(func(ctx context.Context) {
@@ -50,6 +53,15 @@ var _ = Describe("docker", Ordered, ContinueOnFailure, func() {
 			err = installer.Install()
 			Expect(err).ToNot(HaveOccurred())
 		}
+
+		driverOutput, _, err := runner.Run("nvidia-smi -q | grep \"Driver Version\"")
+		Expect(err).ToNot(HaveOccurred())
+		parts := strings.SplitN(driverOutput, ":", 2)
+		Expect(parts).To(HaveLen(2))
+
+		hostDriverVersion = strings.TrimSpace(parts[1])
+		Expect(hostDriverVersion).ToNot(BeEmpty())
+		hostDriverMajor = strings.SplitN(hostDriverVersion, ".", 2)[0]
 	})
 
 	// GPUs are accessible in a container: Running nvidia-smi -L inside the
@@ -184,16 +196,7 @@ var _ = Describe("docker", Ordered, ContinueOnFailure, func() {
 			compatDriverVersion := strings.TrimPrefix(filepath.Base(compatOutput), "libcuda.so.")
 			compatMajor := strings.SplitN(compatDriverVersion, ".", 2)[0]
 
-			driverOutput, _, err := runner.Run("nvidia-smi -q | grep \"Driver Version\"")
-			Expect(err).ToNot(HaveOccurred())
-			parts := strings.SplitN(driverOutput, ":", 2)
-			Expect(parts).To(HaveLen(2))
-
-			hostDriverVersion := strings.TrimSpace(parts[1])
-			Expect(hostDriverVersion).ToNot(BeEmpty())
-			driverMajor := strings.SplitN(hostDriverVersion, ".", 2)[0]
-
-			if driverMajor >= compatMajor {
+			if hostDriverMajor >= compatMajor {
 				GinkgoLogr.Info("CUDA Forward Compatibility tests require an older driver version", "hostDriverVersion", hostDriverVersion, "compatDriverVersion", compatDriverVersion)
 				Skip("CUDA Forward Compatibility tests require an older driver version")
 			}
@@ -241,6 +244,8 @@ var _ = Describe("docker", Ordered, ContinueOnFailure, func() {
 		BeforeAll(func(ctx context.Context) {
 			_, _, err := runner.Run("docker pull ubuntu")
 			Expect(err).ToNot(HaveOccurred())
+			_, _, err = runner.Run("docker pull busybox")
+			Expect(err).ToNot(HaveOccurred())
 		})
 
 		It("should include libcuda.so in the ldcache", func(ctx context.Context) {
@@ -257,6 +262,77 @@ var _ = Describe("docker", Ordered, ContinueOnFailure, func() {
 
 			Expect(libs).To(ContainElements([]string{"libcuda.so", "libcuda.so.1"}))
 		})
+
+		It("should include .so and SONAME symlinks", func(ctx context.Context) {
+			symlinkOutput, _, err := runner.Run("docker run --rm -ti --runtime=nvidia --gpus all busybox  ls -l /usr/lib/x86_64-linux-gnu/ | awk '{print $9, $11}'")
+			Expect(err).ToNot(HaveOccurred())
+			Expect(symlinkOutput).ToNot(BeEmpty())
+
+			// This produces output similar to:
+			// We check this to ensure that we have valid driver library symlink
+			// chains.
+			// libcuda.so libcuda.so.1
+			// libcuda.so.1 libcuda.so.570.133.20
+			// libcuda.so.570.133.20
+			// libcudadebugger.so libcudadebugger.so.1
+			// libcudadebugger.so.1 libcudadebugger.so.570.133.20
+			// libcudadebugger.so.570.133.20
+			// libnvidia-ml.so libnvidia-ml.so.1
+			// libnvidia-ml.so.1 libnvidia-ml.so.570.133.20
+			// libnvidia-ml.so.570.133.20
+			// libnvidia-nvvm.so libnvidia-nvvm.so.4
+			// libnvidia-nvvm.so.4 libnvidia-nvvm.so.570.133.20
+			// libnvidia-nvvm.so.570.133.20
+			// libnvidia-opencl.so libnvidia-opencl.so.1
+			// libnvidia-opencl.so.1 libnvidia-opencl.so.570.133.20
+			// libnvidia-opencl.so.570.133.20
+			// libnvidia-pkcs11-openssl3.so.570.133.20
+			// libnvidia-pkcs11.so.570.133.20
+			// libnvidia-ptxjitcompiler.so libnvidia-ptxjitcompiler.so.1
+			// libnvidia-ptxjitcompiler.so.1 libnvidia-ptxjitcompiler.so.570.133.20
+			// libnvidia-ptxjitcompiler.so.570.133.20
+
+			symlinkOutputLines := strings.Split(symlinkOutput, "\n")
+			var symlinks []string
+			var chain []string
+			for _, line := range symlinkOutputLines {
+				if strings.TrimSpace(line) == "" {
+					continue
+				}
+				parts := strings.SplitN(line, " ", 2)
+				chain = append(chain, parts...)
+				if len(parts) == 1 {
+					Expect(line).To(HaveSuffix(hostDriverMajor))
+					Expect(chain).To(Or(HaveLen(5), HaveLen(1)))
+
+					if len(chain) == 1 {
+						continue
+					}
+
+					// The symlink chains have the pattern:
+					// [A, A.1, A.1, A.driverVersion, A.driverVersion]
+					// A has the suffix .so.
+					Expect(chain[0]).To(HaveSuffix(".so"))
+					for i, c := range chain {
+						if i == 0 {
+							continue
+						}
+						Expect(c).To(HavePrefix(chain[0]))
+						if i == 2 || i == 4 {
+							Expect(c).To(Equal(chain[i-1]))
+						}
+						if i == 3 {
+							Expect(c).To(HaveSuffix(hostDriverVersion))
+						}
+					}
+
+					symlinks = append(symlinks, chain[0])
+					chain = nil
+				}
+			}
+			Expect(chain).To(BeNil())
+			Expect(symlinks).To(ContainElements("libcuda.so", "libnvidia-ml.so"))
+		})
 	})
 
 	When("Running containers with shared mount propagation", Ordered, func() {