Skip to content

Commit 2b493e3

Browse files
committed
Disable nvsandboxutils in nvcdi API
Repeated calls to nvsandboxutils.Init and Shutdown are causing segmentation violations. Here we disabled nvsandbox utils unless explicitly specified. Signed-off-by: Evan Lezar <[email protected]>
1 parent 65b575f commit 2b493e3

File tree

1 file changed

+16
-13
lines changed

1 file changed

+16
-13
lines changed

pkg/nvcdi/lib.go

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -99,19 +99,22 @@ func New(opts ...Option) (Interface, error) {
9999
}
100100
l.nvmllib = nvml.New(nvmlOpts...)
101101
}
102-
if l.nvsandboxutilslib == nil {
103-
var nvsandboxutilsOpts []nvsandboxutils.LibraryOption
104-
// Set the library path for libnvidia-sandboxutils
105-
candidates, err := l.driver.Libraries().Locate("libnvidia-sandboxutils.so.1")
106-
if err != nil {
107-
l.logger.Warningf("Ignoring error in locating libnvidia-sandboxutils.so.1: %v", err)
108-
} else {
109-
libNvidiaSandboxutilsPath := candidates[0]
110-
l.logger.Infof("Using %v", libNvidiaSandboxutilsPath)
111-
nvsandboxutilsOpts = append(nvsandboxutilsOpts, nvsandboxutils.WithLibraryPath(libNvidiaSandboxutilsPath))
112-
}
113-
l.nvsandboxutilslib = nvsandboxutils.New(nvsandboxutilsOpts...)
114-
}
102+
// TODO: Repeated calls to nvsandboxutils.Init and Shutdown are causing
103+
// segmentation violations. Here we disabled nvsandbox utils unless explicitly
104+
// specified.
105+
// if l.nvsandboxutilslib == nil {
106+
// var nvsandboxutilsOpts []nvsandboxutils.LibraryOption
107+
// // Set the library path for libnvidia-sandboxutils
108+
// candidates, err := l.driver.Libraries().Locate("libnvidia-sandboxutils.so.1")
109+
// if err != nil {
110+
// l.logger.Warningf("Ignoring error in locating libnvidia-sandboxutils.so.1: %v", err)
111+
// } else {
112+
// libNvidiaSandboxutilsPath := candidates[0]
113+
// l.logger.Infof("Using %v", libNvidiaSandboxutilsPath)
114+
// nvsandboxutilsOpts = append(nvsandboxutilsOpts, nvsandboxutils.WithLibraryPath(libNvidiaSandboxutilsPath))
115+
// }
116+
// l.nvsandboxutilslib = nvsandboxutils.New(nvsandboxutilsOpts...)
117+
// }
115118
if l.devicelib == nil {
116119
l.devicelib = device.New(l.nvmllib)
117120
}

0 commit comments

Comments
 (0)