Skip to content

Commit 0920018

Browse files
Merge pull request #1201 from ArangoGutierrez/multiple_drivers_e2e
[no-relnote] Test multiple driver branches during E2E
2 parents 81cdd4e + 6bbae56 commit 0920018

File tree

3 files changed

+46
-5
lines changed

3 files changed

+46
-5
lines changed

.github/workflows/e2e.yaml

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,16 @@ on:
3737
jobs:
3838
e2e-tests:
3939
runs-on: linux-amd64-cpu4
40+
strategy:
41+
matrix:
42+
is_pull_request:
43+
- ${{!( startsWith(github.ref, 'refs/pull/') )}}
44+
driver_branch:
45+
- 550
46+
- 575
47+
exclude:
48+
- is_pull_request: true
49+
driver_branch: 575
4050
steps:
4151
- name: Check out code
4252
uses: actions/checkout@v4
@@ -54,21 +64,21 @@ jobs:
5464
with:
5565
go-version: ${{ env.GOLANG_VERSION }}
5666

57-
- name: Set up Holodeck
67+
- name: Set up Holodeck (${{ matrix.driver_branch }})
5868
uses: NVIDIA/[email protected]
5969
with:
6070
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
6171
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
6272
aws_ssh_key: ${{ secrets.AWS_SSH_KEY }}
63-
holodeck_config: "tests/e2e/infra/aws.yaml"
73+
holodeck_config: tests/e2e/infra/driver-branch-${{ matrix.driver_branch }}.yaml
6474

6575
- name: Get public dns name
6676
id: holodeck_public_dns_name
6777
uses: mikefarah/yq@master
6878
with:
6979
cmd: yq '.status.properties[] | select(.name == "public-dns-name") | .value' /github/workspace/.cache/holodeck.yaml
7080

71-
- name: Run e2e tests
81+
- name: Run e2e tests (${{ matrix.driver_branch }})
7282
env:
7383
E2E_INSTALL_CTK: "true"
7484
E2E_IMAGE_NAME: ghcr.io/nvidia/container-toolkit
@@ -86,9 +96,10 @@ jobs:
8696
- name: Archive Ginkgo logs
8797
uses: actions/upload-artifact@v4
8898
with:
89-
name: ginkgo-logs
99+
name: ginkgo-logs-${{ matrix.driver_branch }}
90100
path: ginkgo.json
91101
retention-days: 15
102+
92103
- name: Send Slack alert notification
93104
if: ${{ failure() }}
94105
uses: slackapi/[email protected]
@@ -98,6 +109,6 @@ jobs:
98109
payload: |
99110
channel: ${{ secrets.SLACK_CHANNEL_ID }}
100111
text: |
101-
:x: On repository ${{ github.repository }}, the Workflow *${{ github.workflow }}* has failed.
112+
:x: On repository ${{ github.repository }}, the Workflow *${{ github.workflow }}-driver-branch-${{ matrix.driver_branch }}* has failed.
102113
103114
Details: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}
File renamed without changes.
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
apiVersion: holodeck.nvidia.com/v1alpha1
2+
kind: Environment
3+
metadata:
4+
name: HOLODECK_NAME
5+
description: "end-to-end test infrastructure"
6+
spec:
7+
provider: aws
8+
auth:
9+
keyName: cnt-ci
10+
privateKey: HOLODECK_PRIVATE_KEY
11+
instance:
12+
type: g4dn.xlarge
13+
region: us-west-1
14+
ingressIpRanges:
15+
- 18.190.12.32/32
16+
- 3.143.46.93/32
17+
- 44.230.241.223/32
18+
- 44.235.4.62/32
19+
- 52.15.119.136/32
20+
- 52.24.205.48/32
21+
image:
22+
architecture: amd64
23+
containerRuntime:
24+
install: true
25+
name: docker
26+
nvidiaContainerToolkit:
27+
install: false
28+
nvidiaDriver:
29+
install: true
30+
branch: 575

0 commit comments

Comments
 (0)