RPM: symlinks in /etc/nvidia-mig-manager are not recreated when doing a dnf update or reinstall

[KeithMnemonic]

When trying to update or reinstall the nvidia-mig-manager rpm package, the two symlinks in /etc/nvidia-mig-manager are not recreated.

sudo dnf install nvidia-mig-manager
Last metadata expiration check: 1:20:59 ago on Thu 05 Dec 2024 05:16:44 AM PST.
Dependencies resolved.
===================================================================================================================================================================================================================================================================================
 Package                                                                 Architecture                                                Version                                                         Repository                                                               Size
===================================================================================================================================================================================================================================================================================
Installing:
 nvidia-mig-manager                                                      x86_64                                                      0.10.0-1                                                        nvidia-dgx-9-local                                                      2.1 M

Transaction Summary
===================================================================================================================================================================================================================================================================================
Install  1 Package

Total size: 2.1 M
Installed size: 7.7 M
Is this ok [y/N]: y
Downloading Packages:
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                                                                                                                                           1/1
  Installing       : nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        1/1
  Running scriptlet: nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        1/1
Created symlink /etc/systemd/system/multi-user.target.wants/nvidia-mig-manager.service → /usr/lib/systemd/system/nvidia-mig-manager.service.
Created symlink /etc/systemd/system/nvidia-gpu-reset.target.wants/nvidia-mig-manager.service → /usr/lib/systemd/system/nvidia-mig-manager.service.

  Verifying        : nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        1/1

Installed:
  nvidia-mig-manager-0.10.0-1.x86_64

Complete!


ls -al /etc/nvidia-mig-manager/
total 44
drwxr-xr-x.   2 root root  172 Dec  5 06:37 .
drwxr-xr-x. 120 root root 8192 Dec  5 06:37 ..
-rw-r--r--.   1 root root 6564 Oct 25 11:23 config-default.yaml
lrwxrwxrwx.   1 root root   19 Dec  5 06:37 config.yaml -> config-default.yaml
-rw-r--r--.   1 root root  631 Oct 25 11:23 hooks-default.yaml
-rw-r--r--.   1 root root  191 Oct 25 11:23 hooks-minimal.yaml
-rw-r--r--.   1 root root 2629 Oct 25 11:23 hooks.sh
lrwxrwxrwx.   1 root root   18 Dec  5 06:37 hooks.yaml -> hooks-minimal.yaml
-rwxr-xr-x.   1 root root 2499 Oct 25 11:23 service.sh
-rw-r--r--.   1 root root 4445 Oct 25 11:23 utils.sh

 sudo dnf reinstall nvidia-mig-manager
Last metadata expiration check: 1:21:11 ago on Thu 05 Dec 2024 05:16:44 AM PST.
Dependencies resolved.
===================================================================================================================================================================================================================================================================================
 Package                                                                 Architecture                                                Version                                                         Repository                                                               Size
===================================================================================================================================================================================================================================================================================
Reinstalling:
 nvidia-mig-manager                                                      x86_64                                                      0.10.0-1                                                        nvidia-dgx-9-local                                                      2.1 M

Transaction Summary
===================================================================================================================================================================================================================================================================================

Total size: 2.1 M
Installed size: 7.7 M
Is this ok [y/N]: y
Downloading Packages:
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                                                                                                                                                           1/1
  Reinstalling     : nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        1/2
  Running scriptlet: nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        1/2
  Running scriptlet: nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        2/2
Removed "/etc/systemd/system/multi-user.target.wants/nvidia-mig-manager.service".
Removed "/etc/systemd/system/nvidia-gpu-reset.target.wants/nvidia-mig-manager.service".

  Cleanup          : nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        2/2
  Running scriptlet: nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        2/2
  Verifying        : nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        1/2
  Verifying        : nvidia-mig-manager-0.10.0-1.x86_64                                                                                                                                                                                                                        2/2

Reinstalled:
  nvidia-mig-manager-0.10.0-1.x86_64

Complete!

ls -al /etc/nvidia-mig-manager/
total 44
drwxr-xr-x.   2 root root  135 Dec  5 06:37 .
drwxr-xr-x. 120 root root 8192 Dec  5 06:37 ..
-rw-r--r--.   1 root root 6564 Oct 25 11:23 config-default.yaml
-rw-r--r--.   1 root root  631 Oct 25 11:23 hooks-default.yaml
-rw-r--r--.   1 root root  191 Oct 25 11:23 hooks-minimal.yaml
-rw-r--r--.   1 root root 2629 Oct 25 11:23 hooks.sh
-rwxr-xr-x.   1 root root 2499 Oct 25 11:23 service.sh
-rw-r--r--.   1 root root 4445 Oct 25 11:23 utils.sh

Workaround:

1. remove nvidia-mig-manager sudo dnf remove nvidia-mig-manager
2. install fresh sudo dnf install nvidia-mig-manager

[KeithMnemonic]

You can see from the logs that the %post for 0.10.0 come BEFORE the %preun for 0.7.0

D: %post(nvidia-mig-manager-0.10.0-1.x86_64): waitpid(3057525) rc 3057525 status 0
ufdio:       5 reads,     8468 total bytes in 0.000006 secs
D: ========== +++ nvidia-mig-manager-0.7.0-1 x86_64-linux 0x2
D:     erase: nvidia-mig-manager-0.7.0-1.x86_64 has 15 files
D: Plugin: calling hook psm_pre in selinux plugin
D: %preun(nvidia-mig-manager-0.7.0-1.x86_64): scriptlet start
fdio:       2 writes,      726 total bytes in 0.000010 secs
D: %preun(nvidia-mig-manager-0.7.0-1.x86_64): execv(/bin/sh) pid 3057570
D: Plugin: calling hook scriptlet_fork_post in selinux plugin
D: setexecfilecon: (/bin/sh, rpm_script_t)
+ systemctl disable nvidia-mig-manager.service
Removed "/etc/systemd/system/multi-user.target.wants/nvidia-mig-manager.service".
Removed "/etc/systemd/system/nvidia-gpu-reset.target.wants/nvidia-mig-manager.service".
+ systemctl daemon-reload
+ maybe_remove_hooks_symlink
++ readlink -f /etc/nvidia-mig-manager/hooks.yaml
+ local target=/etc/nvidia-mig-manager/hooks-minimal.yaml
+ '[' /etc/nvidia-mig-manager/hooks-minimal.yaml = /etc/nvidia-mig-manager/hooks-minimal.yaml ']'
+ rm -rf /etc/nvidia-mig-manager/hooks.yaml
+ '[' /etc/nvidia-mig-manager/hooks-minimal.yaml = /etc/nvidia-mig-manager/hooks-default.yaml ']'
+ maybe_remove_config_symlink
++ readlink -f /etc/nvidia-mig-manager/config.yaml
+ local target=/etc/nvidia-mig-manager/config-default.yaml
+ '[' /etc/nvidia-mig-manager/config-default.yaml = /etc/nvidia-mig-manager/config-default.yaml ']'
+ rm -rf /etc/nvidia-mig-manager/config.yaml

[KeithMnemonic]

This probably needs something like

https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#Initscripts_in_spec_file_scriptlets
https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_syntax

i.e.

if [ $1 -eq 0 ]
then
   maybe_remove_hooks_symlink
   maybe_remove_config_symlink
fi

[cdesiniotis]

Closing since #155 has been merged.