Skip to content

Commit 22ef314

Browse files
author
Evan Lezar
committed
Merge branch 'fix-release-ci' into 'master'
Remove push-latest target See merge request nvidia/cloud-native/mig-parted!33
2 parents 53e23b3 + 5fe7c1e commit 22ef314

File tree

3 files changed

+9
-14
lines changed

3 files changed

+9
-14
lines changed

.common-ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,13 +66,12 @@ default:
6666

6767
- 'echo "Deploying ${IN_IMAGE}:${IN_VERSION}-${DIST} as ${OUT_IMAGE}:${OUT_VERSION}-${DIST}"'
6868

69-
# Tag the output image (note the leading v is stripped from the VERSION)
69+
# Tag the output image
7070
- docker tag "${IN_IMAGE}:${IN_VERSION}-${DIST}" "${OUT_IMAGE}:${OUT_VERSION}-${DIST}"
7171

7272
- '[[ -z "${OUT_REGISTRY}" ]] || docker login -u "${OUT_REGISTRY_USER}" -p "${OUT_REGISTRY_TOKEN}" "${OUT_REGISTRY}"'
7373

7474
# Invoke the make target. This includes logic for pushing short / latest versions
75-
# Note: The leading v is stripped from the version
7675
- '[[ -n "${USE_DOCKER_PUSH}" ]] || make IMAGE="${OUT_IMAGE}" VERSION="${OUT_VERSION}" push-${DIST}'
7776
- '[[ -z "${USE_DOCKER_PUSH}" ]] || docker push "${OUT_IMAGE}:${OUT_VERSION}-${DIST}"'
7877

.nvidia-ci.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,21 +63,21 @@ variables:
6363
- docker pull ${IN_IMAGE}:${IN_VERSION}-${DIST}
6464

6565
# .mig-manager-ci-input-image sets the IN_* variables to those of the public CI registry
66-
.mig-manager-public-ci-input-image:
66+
.mig-manager-source-ci-input-image:
6767
variables:
6868
IN_IMAGE: "${SOURCE_REGISTRY}/${SOURCE_IMAGE}"
6969
IN_VERSION: "${CI_COMMIT_SHA}"
7070

71-
# .pull-mig-manager pulls the sha-tagged image from the public CI to the
71+
# .pull-source-mig-manager pulls the sha-tagged image from the public CI to the
7272
# internal CI registry. This allow follow-on stages to work as if the image was
7373
# built in the internal CI.
74-
.pull-mig-manager:
74+
.pull-source-mig-manager:
7575
stage: pull
7676
variables:
7777
USE_DOCKER_PUSH: "yes"
7878
extends:
7979
- .pull-source-image
80-
- .mig-manager-public-ci-input-image
80+
- .mig-manager-source-ci-input-image
8181
- .push-mig-manager
8282
- .mig-manager-ci-output-image
8383

@@ -121,7 +121,7 @@ variables:
121121
script:
122122
- 'echo Dist: ${DIST} ; [[ -n "${DIST}" ]] || exit 1'
123123

124-
# Tag the output image (note the leading v is stripped from the VERSION)
124+
# Tag the output image
125125
- docker tag "${IN_IMAGE}:${IN_VERSION}-${DIST}" "${OUT_IMAGE}:${OUT_VERSION}-${DIST}"
126126

127127
- apk add --no-cache git
@@ -141,7 +141,7 @@ scan-ubi8:
141141

142142
pull-ubi8:
143143
extends:
144-
- .pull-mig-manager
144+
- .pull-source-mig-manager
145145
- .dist-ubi8
146146

147147
release-ngc-ubi8:
@@ -161,7 +161,7 @@ scan-ubuntu20:
161161

162162
pull-ubuntu20:
163163
extends:
164-
- .pull-mig-manager
164+
- .pull-source-mig-manager
165165
- .dist-ubuntu20
166166

167167
release-ngc-ubuntu20:

deployments/gpu-operator/Makefile

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,15 +38,11 @@ $(PUSH_TARGETS): push-%:
3838
$(DOCKER) push "$(IMAGE):$(VERSION)-$(*)"
3939

4040
# For the default push target we also push the short and latest tags
41-
push-$(DEFAULT_PUSH_TARGET): push-short push-latest
41+
push-$(DEFAULT_PUSH_TARGET): push-short
4242
push-short:
4343
$(DOCKER) tag "$(IMAGE):$(VERSION)-$(DEFAULT_PUSH_TARGET)" "$(IMAGE):$(VERSION)"
4444
$(DOCKER) push "$(IMAGE):$(VERSION)"
4545

46-
push-latest:
47-
$(DOCKER) tag "$(IMAGE):$(VERSION)-$(DEFAULT_PUSH_TARGET)" "$(IMAGE):latest"
48-
$(DOCKER) push "$(IMAGE):latest"
49-
5046

5147
$(TARGETS): %: build-%
5248
$(BUILD_TARGETS): build-%:

0 commit comments

Comments
 (0)