Skip to content

Commit 68e19b1

Browse files
authored
Merge pull request #76 from NVIDIA/ubi9-base
use the ubi9 cuda base and drop the ubi tag suffix from generated images
2 parents 1e6f44a + edb4b7f commit 68e19b1

File tree

7 files changed

+28
-47
lines changed

7 files changed

+28
-47
lines changed

.common-ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@ stages:
3333
- release
3434
- sign
3535

36-
.dist-ubi8:
36+
.dist-ubi9:
3737
variables:
38-
DIST: ubi8
38+
DIST: ubi9
3939

4040
# Define the platform targets
4141
.platform-amd64:
@@ -120,9 +120,9 @@ stages:
120120
variables:
121121
OUT_IMAGE_VERSION: "${CI_COMMIT_TAG}"
122122

123-
release:staging-ubi8:
123+
release:staging-ubi9:
124124
extends:
125125
- .release:staging
126-
- .dist-ubi8
126+
- .dist-ubi9
127127
needs:
128-
- image-ubi8
128+
- image-ubi9

.github/workflows/images.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
runs-on: ubuntu-latest
3434
strategy:
3535
matrix:
36-
dist: [ubi8]
36+
dist: [ubi9]
3737
steps:
3838
- uses: actions/checkout@v4
3939
name: Check out code

.gitlab-ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ include:
3030
script:
3131
- make -f deployments/container/Makefile build-${DIST}
3232

33-
image-ubi8:
33+
image-ubi9:
3434
extends:
3535
- .image-build
36-
- .dist-ubi8
36+
- .dist-ubi9

.nvidia-ci.yml

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -57,23 +57,23 @@ variables:
5757
- !reference [.regctl-setup, before_script]
5858
- apk add --no-cache make bash
5959
- >
60-
regctl manifest get ${IN_REGISTRY}/${IN_IMAGE_NAME}:${IN_VERSION}-ubi8 --list > /dev/null && echo "${IN_REGISTRY}/${IN_IMAGE_NAME}:${IN_VERSION}-${DIST}" || ( echo "${IN_REGISTRY}/${IN_IMAGE_NAME}:${IN_VERSION}-${DIST} does not exist" && sleep infinity )
60+
regctl manifest get ${IN_REGISTRY}/${IN_IMAGE_NAME}:${IN_VERSION} --list > /dev/null && echo "${IN_REGISTRY}/${IN_IMAGE_NAME}:${IN_VERSION}" || ( echo "${IN_REGISTRY}/${IN_IMAGE_NAME}:${IN_VERSION} does not exist" && sleep infinity )
6161
script:
6262
- regctl registry login "${OUT_REGISTRY}" -u "${OUT_REGISTRY_USER}" -p "${OUT_REGISTRY_TOKEN}"
63-
- make -f deployments/container/Makefile IMAGE=${IN_REGISTRY}/${IN_IMAGE_NAME}:${IN_VERSION}-${DIST} OUT_IMAGE=${OUT_IMAGE_NAME}:${CI_COMMIT_SHORT_SHA}-${DIST} push-${DIST}
63+
- make -f deployments/container/Makefile IMAGE=${IN_REGISTRY}/${IN_IMAGE_NAME}:${IN_VERSION} OUT_IMAGE=${OUT_IMAGE_NAME}:${CI_COMMIT_SHORT_SHA} push-${DIST}
6464

65-
image-ubi8:
65+
image-ubi9:
6666
extends:
6767
- .image-pull
68-
- .dist-ubi8
68+
- .dist-ubi9
6969

7070
# The .scan step forms the base of the image scan operation performed before releasing
7171
# images.
7272
.scan:
7373
stage: scan
7474
image: "${PULSE_IMAGE}"
7575
variables:
76-
IMAGE: "${CI_REGISTRY_IMAGE}:${CI_COMMIT_SHORT_SHA}-${DIST}"
76+
IMAGE: "${CI_REGISTRY_IMAGE}:${CI_COMMIT_SHORT_SHA}"
7777
IMAGE_ARCHIVE: "k8s-kata-manager.tar"
7878
except:
7979
variables:
@@ -102,13 +102,13 @@ image-ubi8:
102102
scan-amd64:
103103
extends:
104104
- .scan
105-
- .dist-ubi8
105+
- .dist-ubi9
106106
- .platform-amd64
107107

108108
scan-arm64:
109109
extends:
110110
- .scan
111-
- .dist-ubi8
111+
- .dist-ubi9
112112
- .platform-arm64
113113

114114
# Define the external release helpers
@@ -122,10 +122,10 @@ scan-arm64:
122122

123123
# Define the external release targets
124124
# Release to NGC
125-
release:ngc-ubi8:
125+
release:ngc-ubi9:
126126
extends:
127127
- .release:ngc
128-
- .dist-ubi8
128+
- .dist-ubi9
129129

130130
# Define the external image signing steps for NGC
131131
# Download the ngc cli binary for use in the sign steps
@@ -154,7 +154,7 @@ release:ngc-ubi8:
154154
variables:
155155
NGC_CLI_API_KEY: "${NGC_REGISTRY_TOKEN}"
156156
IMAGE_NAME: "${NGC_REGISTRY_IMAGE}"
157-
IMAGE_TAG: "${CI_COMMIT_TAG}-${DIST}"
157+
IMAGE_TAG: "${CI_COMMIT_TAG}"
158158
retry:
159159
max: 2
160160
before_script:
@@ -166,17 +166,9 @@ release:ngc-ubi8:
166166
- 'echo "Signing the image ${IMAGE_NAME}:${IMAGE_TAG}"'
167167
- ngc-cli/ngc registry image publish --source ${IMAGE_NAME}:${IMAGE_TAG} ${IMAGE_NAME}:${IMAGE_TAG} --public --discoverable --allow-guest --sign --org nvidia
168168

169-
sign:ngc-short-tag:
170-
extends:
171-
- .sign:ngc
172-
variables:
173-
IMAGE_TAG: "${CI_COMMIT_TAG}"
174-
needs:
175-
- release:ngc-ubi8
176-
177-
sign:ngc-ubi8:
169+
sign:ngc-ubi9:
178170
extends:
179-
- .dist-ubi8
171+
- .dist-ubi9
180172
- .sign:ngc
181173
needs:
182-
- release:ngc-ubi8
174+
- release:ngc-ubi9

deployments/container/Dockerfile.ubi8 renamed to deployments/container/Dockerfile.ubi9

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
ARG GOLANG_VERSION=x.x.x
1616
ARG VERSION="N/A"
1717

18-
FROM nvcr.io/nvidia/cuda:12.6.2-base-ubi8 as build
18+
FROM nvcr.io/nvidia/cuda:12.6.2-base-ubi9 as build
1919

2020
RUN yum install -y wget make git gcc
2121

@@ -43,7 +43,7 @@ ARG VERSION="N/A"
4343
ARG GIT_COMMIT="unknown"
4444
RUN make PREFIX=/artifacts cmds
4545

46-
FROM nvcr.io/nvidia/cuda:12.6.2-base-ubi8
46+
FROM nvcr.io/nvidia/cuda:12.6.2-base-ubi9
4747

4848
COPY --from=build /artifacts/k8s-kata-manager /usr/bin/k8s-kata-manager
4949

deployments/container/Makefile

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,18 +27,15 @@ ifeq ($(IMAGE_NAME),)
2727
IMAGE_NAME := $(REGISTRY)/$(NAME)
2828
endif
2929

30-
IMAGE_VERSION := $(VERSION)
31-
32-
IMAGE_TAG ?= $(IMAGE_VERSION)-$(DIST)
30+
IMAGE_TAG ?= $(VERSION)
3331
IMAGE = $(IMAGE_NAME):$(IMAGE_TAG)
3432

3533
OUT_IMAGE_NAME ?= $(IMAGE_NAME)
36-
OUT_IMAGE_VERSION ?= $(IMAGE_VERSION)
37-
OUT_IMAGE_TAG = $(OUT_IMAGE_VERSION)-$(DIST)
38-
OUT_IMAGE = $(OUT_IMAGE_NAME):$(OUT_IMAGE_TAG)
34+
OUT_IMAGE_VERSION ?= $(VERSION)
35+
OUT_IMAGE = $(OUT_IMAGE_NAME):$(OUT_IMAGE_VERSION)
3936

4037
##### Public rules #####
41-
DEFAULT_PUSH_TARGET := ubi8
38+
DEFAULT_PUSH_TARGET := ubi9
4239
DISTRIBUTIONS = $(DEFAULT_PUSH_TARGET)
4340

4441
IMAGE_TARGETS := $(patsubst %,image-%,$(DISTRIBUTIONS))
@@ -87,7 +84,7 @@ $(IMAGE_TARGETS): image-%:
8784

8885
build-ubuntu%: DOCKERFILE_SUFFIX := ubuntu
8986

90-
build-ubi8: DOCKERFILE_SUFFIX := ubi8
87+
build-ubi9: DOCKERFILE_SUFFIX := ubi9
9188

9289
# Handle the default build target.
9390
.PHONY: build

deployments/container/native-only.mk

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,3 @@ $(BUILD_TARGETS): build-%: image-%
2121
else
2222
$(BUILD_TARGETS): build-%: image-%
2323
endif
24-
25-
# For the default distribution we also retag the image.
26-
# Note: This needs to be updated for multi-arch images.
27-
ifeq ($(IMAGE_TAG),$(VERSION)-$(DIST))
28-
$(DEFAULT_PUSH_TARGET):
29-
$(DOCKER) image inspect $(IMAGE) > /dev/null || $(DOCKER) pull $(IMAGE)
30-
$(DOCKER) tag $(IMAGE) $(subst :$(IMAGE_TAG),:$(VERSION),$(IMAGE))
31-
endif

0 commit comments

Comments
 (0)