Skip to content

Ensure attestation parameters are passed only for multi-arch builds using buildx. #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
Merged

Ensure attestation parameters are passed only for multi-arch builds using buildx. #682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deployments/container/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ DOCKER ?= docker
REGCTL ?= regctl
BUILDX =
PUSH_ON_BUILD ?= false
ATTACH_ATTESTATIONS ?= false

##### Global variables #####
include $(CURDIR)/versions.mk
Expand All @@ -39,7 +40,7 @@ IMAGE = $(IMAGE_NAME):$(IMAGE_TAG)

ifeq ($(BUILD_MULTI_ARCH_IMAGES),true)
BUILDX = buildx
DOCKER_BUILD_OPTIONS = --output=type=image,push=$(PUSH_ON_BUILD)
DOCKER_BUILD_OPTIONS = --output=type=image,push=$(PUSH_ON_BUILD) --provenance=$(ATTACH_ATTESTATIONS) --sbom=$(ATTACH_ATTESTATIONS)
DOCKER_BUILD_PLATFORM_OPTIONS = --platform=linux/amd64,linux/arm64
else
# We also support building single-platform images.
Expand All @@ -58,7 +59,6 @@ DOCKERFILE = $(CURDIR)/deployments/container/Dockerfile
build:
DOCKER_BUILDKIT=1 \
$(DOCKER) $(BUILDX) build --pull \
--provenance=false --sbom=false \
$(DOCKER_BUILD_OPTIONS) \
$(DOCKER_BUILD_PLATFORM_OPTIONS) \
--tag $(IMAGE) \
Expand Down