Merge pull request #316 from NVIDIA/golangci-lint-v2

[CI] migrate to golangci-lint v2

Author: elezar

.github/workflows/golang.yaml

@@ -34,7 +34,7 @@ jobs:
         go-version: ${{ inputs.golang_versions }}
 
     - name: Lint
-      uses: golangci/golangci-lint-action@v6
+      uses: golangci/golangci-lint-action@v7
       with:
         version: latest
         args: -v --timeout 5m

.golangci.yaml

@@ -1,20 +1,37 @@
-# please keep this alphabetized
+version: "2"
+run:
+  tests: true
 linters:
   enable:
     - asciicheck
     - contextcheck
     - forcetypeassert
     - gocritic
     - godot
+    - misspell
+    - staticcheck
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
     - gofmt
     - goimports
-    - misspell
-    - stylecheck
-
-run:
-  tests: true
-  timeout: 10m
-
-linters-settings:
-  goimports:
-    local-prefixes: "github.com/NVIDIA/k8s-dra-driver-gpu"
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/NVIDIA/k8s-dra-driver-gpu
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

cmd/compute-domain-kubelet-plugin/cdi.go

@@ -161,8 +161,8 @@ func (cdi *CDIHandler) CreateStandardDeviceSpecFile(allocatable AllocatableDevic
 	// Make sure that NVIDIA_VISIBLE_DEVICES is set to void to avoid the
 	// nvidia-container-runtime honoring it in addition to the underlying
 	// runtime honoring CDI.
-	commonEdits.ContainerEdits.Env = append(
-		commonEdits.ContainerEdits.Env,
+	commonEdits.Env = append(
+		commonEdits.Env,
 		"NVIDIA_VISIBLE_DEVICES=void")
 
 	// Generate device specs for all devices.

cmd/compute-domain-kubelet-plugin/device_state.go

@@ -502,19 +502,19 @@ func GetOpaqueDeviceConfigs(
 	for _, config := range candidateConfigs {
 		// If this is nil, the driver doesn't support some future API extension
 		// and needs to be updated.
-		if config.DeviceConfiguration.Opaque == nil {
+		if config.Opaque == nil {
 			return nil, fmt.Errorf("only opaque parameters are supported by this driver")
 		}
 
 		// Configs for different drivers may have been specified because a
 		// single request can be satisfied by different drivers. This is not
 		// an error -- drivers must skip over other driver's configs in order
 		// to support this.
-		if config.DeviceConfiguration.Opaque.Driver != driverName {
+		if config.Opaque.Driver != driverName {
 			continue
 		}
 
-		decodedConfig, err := runtime.Decode(decoder, config.DeviceConfiguration.Opaque.Parameters.Raw)
+		decodedConfig, err := runtime.Decode(decoder, config.Opaque.Parameters.Raw)
 		if err != nil {
 			return nil, fmt.Errorf("error decoding config parameters: %w", err)
 		}

cmd/gpu-kubelet-plugin/cdi.go

@@ -159,8 +159,8 @@ func (cdi *CDIHandler) CreateStandardDeviceSpecFile(allocatable AllocatableDevic
 	// Make sure that NVIDIA_VISIBLE_DEVICES is set to void to avoid the
 	// nvidia-container-runtime honoring it in addition to the underlying
 	// runtime honoring CDI.
-	commonEdits.ContainerEdits.Env = append(
-		commonEdits.ContainerEdits.Env,
+	commonEdits.Env = append(
+		commonEdits.Env,
 		"NVIDIA_VISIBLE_DEVICES=void")
 
 	// Generate device specs for all full GPUs and MIG devices.

cmd/gpu-kubelet-plugin/device_state.go

@@ -446,19 +446,19 @@ func GetOpaqueDeviceConfigs(
 	for _, config := range candidateConfigs {
 		// If this is nil, the driver doesn't support some future API extension
 		// and needs to be updated.
-		if config.DeviceConfiguration.Opaque == nil {
+		if config.Opaque == nil {
 			return nil, fmt.Errorf("only opaque parameters are supported by this driver")
 		}
 
 		// Configs for different drivers may have been specified because a
 		// single request can be satisfied by different drivers. This is not
 		// an error -- drivers must skip over other driver's configs in order
 		// to support this.
-		if config.DeviceConfiguration.Opaque.Driver != driverName {
+		if config.Opaque.Driver != driverName {
 			continue
 		}
 
-		decodedConfig, err := runtime.Decode(decoder, config.DeviceConfiguration.Opaque.Parameters.Raw)
+		decodedConfig, err := runtime.Decode(decoder, config.Opaque.Parameters.Raw)
 		if err != nil {
 			return nil, fmt.Errorf("error decoding config parameters: %w", err)
 		}