Add more logs to computedomain manager

Signed-off-by: Swati Gupta <[email protected]>

Author: guptaNswati

cmd/compute-domain-controller/computedomain.go

@@ -64,11 +64,13 @@ func NewComputeDomainManager(config *ManagerConfig) *ComputeDomainManager {
 	factory := nvinformers.NewSharedInformerFactory(config.clientsets.Nvidia, informerResyncPeriod)
 	informer := factory.Resource().V1beta1().ComputeDomains().Informer()
 
+	klog.Infof("Creating new ComputeDomainManager with config %+v", config)
 	m := &ComputeDomainManager{
 		config:   config,
 		factory:  factory,
 		informer: informer,
 	}
+	// TODO (swati) add logs for daemonset and resourceClaimTemplate managers in verbose mode
 	m.daemonSetManager = NewDaemonSetManager(config, m.Get)
 	m.resourceClaimTemplateManager = NewWorkloadResourceClaimTemplateManager(config, m.Get)
 
@@ -97,6 +99,8 @@ func (m *ComputeDomainManager) Start(ctx context.Context) (rerr error) {
 
 	_, err = m.informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
 		AddFunc: func(obj any) {
+			cd := obj.(*nvapi.ComputeDomain)
+			klog.Infof("ComputeDomain %s/%s added to work queue", cd.Namespace, cd.Name)
 			m.config.workQueue.Enqueue(obj, m.onAddOrUpdate)
 		},
 		UpdateFunc: func(oldObj, newObj any) {
@@ -147,6 +151,7 @@ func (m *ComputeDomainManager) Get(uid string) (*nvapi.ComputeDomain, error) {
 		return nil, fmt.Errorf("error retrieving ComputeDomain by UID: %w", err)
 	}
 	if len(cds) == 0 {
+		klog.Infof("No ComputeDomain found with UID: %s", uid)
 		return nil, nil
 	}
 	if len(cds) != 1 {
@@ -166,11 +171,12 @@ func (m *ComputeDomainManager) RemoveFinalizer(ctx context.Context, uid string)
 		return fmt.Errorf("error retrieving ComputeDomain: %w", err)
 	}
 	if cd == nil {
+		klog.Infof("ComputeDomain with UID %s not found, nothing to do", uid)
 		return nil
 	}
 
 	if cd.GetDeletionTimestamp() == nil {
-		return fmt.Errorf("attempting to remove finalizer before ComputeDomain marked for deletion")
+		return fmt.Errorf("attempting to remove finalizer before ComputeDomain %s/%s with UID %s marked for deletion", cd.Namespace, cd.Name, uid)
 	}
 
 	newCD := cd.DeepCopy()
@@ -181,13 +187,13 @@ func (m *ComputeDomainManager) RemoveFinalizer(ctx context.Context, uid string)
 		}
 	}
 	if len(cd.Finalizers) == len(newCD.Finalizers) {
+		klog.Infof("Finalizer not found on ComputeDomain %s/%s, nothing to do", cd.Namespace, cd.Name)
 		return nil
 	}
 
 	if _, err = m.config.clientsets.Nvidia.ResourceV1beta1().ComputeDomains(cd.Namespace).Update(ctx, newCD, metav1.UpdateOptions{}); err != nil {
 		return fmt.Errorf("error updating ComputeDomain: %w", err)
 	}
-
 	return nil
 }
 
@@ -215,9 +221,38 @@ func (m *ComputeDomainManager) AssertWorkloadsCompleted(ctx context.Context, cdU
 	}
 
 	if len(nodes.Items) != 0 {
+		// show nodes with labels
+		nodeNames := []string{}
+		for _, node := range nodes.Items {
+			nodeNames = append(nodeNames, node.Name)
+		}
+		klog.Errorf("Found %d nodes with label for ComputeDomain with UID  %s: %v", len(nodes.Items), cdUID, nodeNames)
 		return fmt.Errorf("nodes exist with label for ComputeDomain %s", cdUID)
 	}
 
+	// check if all resource claims for workloads are gone
+	cd, err := m.Get(cdUID)
+	if err != nil {
+		return fmt.Errorf("error retrieving ComputeDomain: %w", err)
+	}
+
+	resourceClaims, err := m.config.clientsets.Core.ResourceV1beta1().ResourceClaims(cd.Namespace).List(ctx, metav1.ListOptions{
+		LabelSelector: metav1.FormatLabelSelector(labelSelector),
+	})
+	if err != nil {
+		return fmt.Errorf("error retrieving ResourceClaims: %w", err)
+	}
+
+	if len(resourceClaims.Items) != 0 {
+		claimNames := []string{}
+		for _, claim := range resourceClaims.Items {
+			claimNames = append(claimNames, claim.Name)
+		}
+		klog.Errorf("Found %d ResourceClaims for ComputeDomain with UID %s: %v",
+			len(resourceClaims.Items), cdUID, claimNames)
+		return fmt.Errorf("ResourceClaims exist for ComputeDomain %s", cdUID)
+	}
+
 	return nil
 }