Add GitHub action for E2E

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

Author: ArangoGutierrez

.github/workflows/ci.yaml

@@ -31,3 +31,13 @@ jobs:
     secrets: inherit
     with:
       version: ${{ needs.basic.outputs.version }}
+
+  e2e-test:
+    needs:
+    - image
+    - basic
+    secrets: inherit
+    uses: ./.github/workflows/e2e.yaml
+    with:
+      version: ${{ needs.basic.outputs.version }}
+      golang_version: ${{ needs.basic.outputs.golang_version }}

.github/workflows/e2e.yaml

@@ -0,0 +1,89 @@
+# Copyright 2025 NVIDIA CORPORATION
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: End-to-end Tests
+
+on:
+  workflow_call:
+    inputs:
+      version:
+        required: true
+        type: string
+      golang_version:
+        required: true
+        type: string
+    secrets:
+      AWS_ACCESS_KEY_ID:
+        required: true
+      AWS_SECRET_ACCESS_KEY:
+        required: true
+      AWS_SSH_KEY:
+        required: true
+      SLACK_BOT_TOKEN:
+        required: true
+      SLACK_CHANNEL_ID:
+        required: true
+
+jobs:
+  e2e-tests:
+    runs-on: linux-amd64-cpu4
+    steps:
+    - name: Check out code
+      uses: actions/checkout@v4
+
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: ${{ inputs.golang_version }}
+
+    - name: Set up Holodeck
+      uses: NVIDIA/[email protected]
+      with:
+        aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
+        aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
+        aws_ssh_key: ${{ secrets.AWS_SSH_KEY }}
+        holodeck_config: "tests/e2e/infra/holodeck.yaml"
+
+    - name: Run e2e tests
+      env:
+        KUBECONFIG: ${{ github.workspace }}/kubeconfig
+        HELM_CHART: ${{ github.workspace }}/deployments/helm/k8s-dra-driver-gpu
+        E2E_IMAGE_REPO: ghcr.io/nvidia/k8s-dra-driver-gpu
+        E2E_IMAGE_TAG: ${{ inputs.version }}-ubi9
+        E2E_IMAGE_PULL_POLICY: IfNotPresent
+        LOG_ARTIFACTS_DIR: ${{ github.workspace }}/e2e_logs
+      run: |
+        make test-e2e
+
+    - name: Archive test logs
+      if: ${{ failure() }}
+      uses: actions/upload-artifact@v4
+      with:
+        name: e2e-test-logs
+        path: ./e2e_logs/
+        retention-days: 15
+
+    - name: Post text to a Slack channel
+      uses: slackapi/[email protected]
+      env:
+        SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
+        SUMMARY_URL: https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}
+      with:
+        method: chat.postMessage
+        token: ${{ secrets.SLACK_BOT_TOKEN }}
+        payload: |
+          channel: ${{ secrets.SLACK_CHANNEL_ID }}
+          text: ":x: On repository ${{ github.repository }} the Workflow *${{ github.workflow }}* has failed.
+
+          Details: ${{ env.SUMMARY_URL }}"

.github/workflows/image.yaml

@@ -28,18 +28,22 @@ jobs:
     steps:
       - uses: actions/checkout@v4
         name: Check out code
+
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3
         with:
           image: tonistiigi/binfmt:qemu-v7.0.0-28
+
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
+
       - name: Login to GitHub Container Registry
         uses: docker/login-action@v3
         with:
           registry: ghcr.io
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
+          
       - name: Build image
         env:
           IMAGE_NAME: ghcr.io/nvidia/k8s-dra-driver-gpu

Makefile

@@ -31,7 +31,7 @@ CMDS := $(patsubst ./cmd/%/,%,$(sort $(dir $(wildcard ./cmd/*/))))
 CMD_TARGETS := $(patsubst %,cmd-%, $(CMDS))
 
 CHECK_TARGETS := golangci-lint check-generate
-MAKE_TARGETS := binaries build build-image check fmt lint-internal test examples cmds coverage generate vendor check-modules $(CHECK_TARGETS) ginkgo
+MAKE_TARGETS := binaries build build-image check fmt lint-internal test test-e2e ginkgo examples cmds coverage generate vendor check-modules $(CHECK_TARGETS)
 
 TARGETS := $(MAKE_TARGETS) $(CMD_TARGETS)
 
@@ -93,13 +93,6 @@ vendor:
 check-modules: vendor
 	git diff --quiet HEAD -- go.mod go.sum vendor
 
-ginkgo: $(CURDIR)/bin/ginkgo
-	mkdir -p $(CURDIR)/bin
-	GOBIN=$(CURDIR)/bin go install github.com/onsi/ginkgo/v2/ginkgo@latest
-
-e2e-test: ginkgo
-	./bin/ginkgo $(GINKGO_ARGS) -v --json-report ginkgo.json ./tests/e2e/...
-
 COVERAGE_FILE := coverage.out
 test: build cmds
 	go test -race -cover -v -coverprofile=$(COVERAGE_FILE) $(MODULE)/...
@@ -108,6 +101,13 @@ coverage: test
 	cat $(COVERAGE_FILE) | grep -v "_mock.go" > $(COVERAGE_FILE).no-mocks
 	go tool cover -func=$(COVERAGE_FILE).no-mocks
 
+ginkgo:
+	mkdir -p $(CURDIR)/bin
+	GOBIN=$(CURDIR)/bin go install github.com/onsi/ginkgo/v2/ginkgo@latest
+
+test-e2e: ginkgo
+	./bin/ginkgo $(GINKGO_ARGS) -v --json-report $(LOG_ARTIFACTS_DIR)/ginkgo.json ./tests/e2e/...
+
 generate: generate-crds generate-informers fmt
 
 generate-crds: generate-deepcopy .remove-crds

hack/e2e-test.sh

@@ -21,23 +21,15 @@ set -o pipefail
 SOURCE_DIR="$(cd "$(dirname -- "${BASH_SOURCE[0]}")" && pwd -P)"
 ROOT_DIR="$SOURCE_DIR/.."
 
-GINKGO="$ROOT_DIR"/bin/ginkgo
-GINKGO_ARGS=${GINKGO_ARGS:-}
-
-# Check if ginkgo binary is present 
-if [ ! -f "$GINKGO" ]; then
-  echo "ginkgo binary not found at $GINKGO, building it"
-  make ginkgo
-fi
-
 HELM_CHART=$ROOT_DIR/deployments/helm/nvidia-dra-driver-gpu
 E2E_IMAGE_REPO=${E2E_IMAGE_REPO:-"ghcr.io/nvidia/k8s-dra-driver-gpu"}
 E2E_IMAGE_TAG=${E2E_IMAGE_TAG:-"93cd4799-ubi9"}
 E2E_IMAGE_PULL_POLICY=${E2E_IMAGE_PULL_POLICY:-"IfNotPresent"}
 ENABLE_GFD=${ENABLE_GFD:-"true"}
 E2E_HOST_MANAGED_DRIVERS=${E2E_HOST_MANAGED_DRIVERS:-"true"}
+LOG_ARTIFACTS_DIR="$ROOT_DIR/e2e_artifacts"
 
-export E2E_IMAGE_REPO HELM_CHART E2E_IMAGE_TAG E2E_IMAGE_PULL_POLICY ENABLE_GFD E2E_HOST_MANAGED_DRIVERS
+export E2E_IMAGE_REPO HELM_CHART E2E_IMAGE_TAG E2E_IMAGE_PULL_POLICY ENABLE_GFD E2E_HOST_MANAGED_DRIVERS LOG_ARTIFACTS_DIR
 
 # shellcheck disable=SC2086
-make e2e-test
+make test-e2e

tests/e2e/e2e_test.go

@@ -214,7 +214,7 @@ func getTestEnv() {
 	HelmChart = os.Getenv("HELM_CHART")
 	Expect(HelmChart).NotTo(BeEmpty(), "HELM_CHART must be set")
 
-	LogArtifactDir = os.Getenv("LOG_ARTIFACT_DIR")
+	LogArtifactDir = os.Getenv("LOG_ARTIFACTS_DIR")
 
 	ImageRepo = os.Getenv("E2E_IMAGE_REPO")
 	Expect(ImageRepo).NotTo(BeEmpty(), "IMAGE_REPO must be set")

tests/e2e/infra/holodeck.yaml

@@ -7,22 +7,36 @@ spec:
   provider: aws
   auth:
     keyName: cnt-ci
-    privateKey: $AWS_PRIVATE_KEY
+    privateKey: HOLODECK_PRIVATE_KEY
+  instance:
+    type: g4dn.xlarge
+    region: us-west-1
+    ingressIpRanges:
+    - 18.190.12.32/32
+    - 3.143.46.93/32
+    - 52.15.119.136/32
+    - 35.155.108.162/32
+    - 35.162.190.51/32
+    - 54.201.61.24/32
+    - 52.24.205.48/32
+    - 44.235.4.62/32
+    - 44.230.241.223/32
   instance:
     type: g4dn.xlarge
     region: us-west-1
     ingressIpRanges:
     - 57.133.151.69/32
     image:
       architecture: amd64
+  containerRuntime:
+    install: true
+    name: containerd
+    version: 1.7.24
   nvidiaDriver:
     install: true
   nvidiaContainerToolkit:
     install: true
-  containerRuntime:
-    install: true
-    name: containerd
-    version: 2.0.0
+    enableCDI: true
   kubernetes:
     install: true
     installer: kubeadm