Skip to content

Commit b6dd25e

Browse files
committed
use continue instead of return
Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
1 parent f4011ef commit b6dd25e

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

cmd/compute-domain-daemon/main.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -334,11 +334,13 @@ func IMEXDaemonUpdateLoopWithDNSNames(ctx context.Context, controller *Controlle
334334

335335
dnsNameManager.LogDNSNameMappings()
336336

337-
// TODO: review skipping this also if the new set of IP addresses
338-
// only strictly removes addresses compared to the old set (then we
339-
// don't need to force the daemon to re-resolve & re-connect).
337+
// Skip sending SIGUSR1 when the process is fresh (has newly been
338+
// created) or when thiss was a noop update. TODO: review skipping
339+
// this also if the new set of IP addresses only strictly removes
340+
// addresses compared to the old set (then we don't need to force
341+
// the daemon to re-resolve & re-connect).
340342
if !updated || fresh {
341-
return nil
343+
continue
342344
}
343345

344346
// Actively ask the IMEX daemon to re-read its config and to

0 commit comments

Comments
 (0)