Skip to content

Commit 738a2bd

Browse files
authored
Merge pull request #267 from elezar/bump-nvidia-container-toolkit
Bump nvcdi package to v1.17.5
2 parents 670f965 + 7980570 commit 738a2bd

File tree

16 files changed

+194
-301
lines changed

16 files changed

+194
-301
lines changed

cmd/compute-domain-kubelet-plugin/cdi.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,8 @@ func NewCDIHandler(opts ...cdiOption) (*CDIHandler, error) {
120120
nvcdi.WithVendor(h.vendor),
121121
nvcdi.WithClass(h.claimClass),
122122
nvcdi.WithNVIDIACDIHookPath(h.nvidiaCTKPath),
123+
// TODO: This should be removed once the use of a NVIDIA Container Toolkit >= v1.17.5 is commonplace.
124+
nvcdi.WithDisabledHook(nvcdi.HookEnableCudaCompat),
123125
)
124126
if err != nil {
125127
return nil, fmt.Errorf("unable to create CDI library for claims: %w", err)

go.mod

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ require (
66
github.com/Masterminds/semver v1.5.0
77
github.com/NVIDIA/go-nvlib v0.7.1
88
github.com/NVIDIA/go-nvml v0.12.4-1
9-
github.com/NVIDIA/nvidia-container-toolkit v1.17.1-0.20250206090248-1d0777ee0165
9+
github.com/NVIDIA/nvidia-container-toolkit v1.17.5-rc.1
1010
github.com/google/uuid v1.6.0
1111
github.com/prometheus/client_golang v1.19.1
1212
github.com/sirupsen/logrus v1.9.3
@@ -56,7 +56,7 @@ require (
5656
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
5757
github.com/modern-go/reflect2 v1.0.2 // indirect
5858
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
59-
github.com/opencontainers/runtime-spec v1.2.0 // indirect
59+
github.com/opencontainers/runtime-spec v1.2.1 // indirect
6060
github.com/opencontainers/runtime-tools v0.9.1-0.20221107090550-2e043c6bd626 // indirect
6161
github.com/pkg/errors v0.9.1 // indirect
6262
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
@@ -89,3 +89,7 @@ require (
8989
sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect
9090
sigs.k8s.io/yaml v1.4.0 // indirect
9191
)
92+
93+
// The k8s-dra-driver does not need to modify the OCI Runtime Specifications and as such
94+
// this transitive dependency is not needed. We skip the transitive update from the new nvcdi version.
95+
replace github.com/opencontainers/runtime-spec v1.2.1 => github.com/opencontainers/runtime-spec v1.2.0

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ github.com/NVIDIA/go-nvlib v0.7.1 h1:7HHPZxoCjSLm1NgaRRjuhI8ffMCpc5Vgpg5yxQYUff8
66
github.com/NVIDIA/go-nvlib v0.7.1/go.mod h1:2Kh2kYSP5IJ8EKf0/SYDzHiQKb9EJkwOf2LQzu6pXzY=
77
github.com/NVIDIA/go-nvml v0.12.4-1 h1:WKUvqshhWSNTfm47ETRhv0A0zJyr1ncCuHiXwoTrBEc=
88
github.com/NVIDIA/go-nvml v0.12.4-1/go.mod h1:8Llmj+1Rr+9VGGwZuRer5N/aCjxGuR5nPb/9ebBiIEQ=
9-
github.com/NVIDIA/nvidia-container-toolkit v1.17.1-0.20250206090248-1d0777ee0165 h1:YYs5V+gwO+qnjLK0yhHGvXGWdbqMOmst/5aJEcIkA1Q=
10-
github.com/NVIDIA/nvidia-container-toolkit v1.17.1-0.20250206090248-1d0777ee0165/go.mod h1:HbdWdB4ukjPWvSIYhNFKthzVuQATUBEXxSskcABWvP0=
9+
github.com/NVIDIA/nvidia-container-toolkit v1.17.5-rc.1 h1:z/+l/9OgYSdgbx83ynKxbOX5V2wP9h7Lh2/b0CvYFZI=
10+
github.com/NVIDIA/nvidia-container-toolkit v1.17.5-rc.1/go.mod h1:UQcbm+GRu+Dwmeyqtwq2HDa57Xq82zzQsmUusidtndM=
1111
github.com/beorn7/perks v1.0.1 h1:VlbKKnNfV8bJzeqoa4cOKqO6bYr3WgKZxO8Z16+hsOM=
1212
github.com/beorn7/perks v1.0.1/go.mod h1:G2ZrVWU2WbWT9wwq4/hrbKbnv/1ERSJQ0ibhJ6rlkpw=
1313
github.com/blang/semver/v4 v4.0.0 h1:1PFHFE6yCCTv8C1TeyNNarDzntLi7wMI5i/pzqYIsAM=

vendor/github.com/NVIDIA/nvidia-container-toolkit/internal/discover/compat_libs.go

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/NVIDIA/nvidia-container-toolkit/internal/lookup/device.go

Lines changed: 1 addition & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/api.go

Lines changed: 28 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/common-nvml.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/driver-nvml.go

Lines changed: 34 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/hooks.go

Lines changed: 30 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/NVIDIA/nvidia-container-toolkit/pkg/nvcdi/lib-imex.go

Lines changed: 0 additions & 118 deletions
This file was deleted.

0 commit comments

Comments
 (0)