File tree Expand file tree Collapse file tree 4 files changed +17
-3
lines changed
helm/nvidia-dra-driver-gpu Expand file tree Collapse file tree 4 files changed +17
-3
lines changed Original file line number Diff line number Diff line change @@ -27,6 +27,10 @@ ifeq ($(IMAGE_NAME),)
2727IMAGE_NAME := $(REGISTRY ) /$(DRIVER_NAME )
2828endif
2929
30+ # Note: this is sometimes a v-prefixed version string
31+ # (in case of proper releases) or sometimes a commit hash
32+ # (in case of regular CI builds) in which case VERSION
33+ # is not v-prefixed.
3034IMAGE_VERSION := $(VERSION )
3135
3236IMAGE_TAG ?= $(IMAGE_VERSION ) -$(DIST )
Original file line number Diff line number Diff line change @@ -15,10 +15,10 @@ type: application
1515# This is the chart version. This version number should be incremented each time you make changes
1616# to the chart and its templates, including the app version.
1717# Versions are expected to follow Semantic Versioning (https://semver.org/)
18- version : v25 .3.0
18+ version : 25 .3.0-rc.1
1919
2020# This is the version number of the application being deployed. This version number should be
2121# incremented each time you make changes to the application. Versions are not expected to
2222# follow Semantic Versioning. They should reflect the version the application is using.
2323# It is recommended to use it with quotes.
24- appVersion : " v25 .3.0"
24+ appVersion : " 25 .3.0-rc.1 "
Original file line number Diff line number Diff line change @@ -19,10 +19,19 @@ set -o pipefail
1919# if arg1 is set, it will be used as the version number
2020if [ -z " $1 " ]; then
2121 VERSION=$( awk -F= ' /^VERSION/ { print $2 }' versions.mk | tr -d ' [:space:]' )
22+ # Remove any v prefix, if exists.
23+ VERSION=" ${VERSION# v} "
2224else
2325 VERSION=$1
2426fi
2527VERSION=${VERSION}
2628
29+
30+ # Note(JP): the goal below is for VERSION to always be
31+ # strictly semver-compliant (parseable with a semver
32+ # parser). That enables best compatibility with the Helm
33+ # ecosystem. For example, that means that no `v` prefix
34+ # should be used here.
35+
2736# Create release assets to be uploaded
2837helm package deployments/helm/nvidia-dra-driver-gpu/ --version $VERSION --app-version $VERSION
Original file line number Diff line number Diff line change @@ -18,7 +18,8 @@ MODULE := github.com/NVIDIA/$(DRIVER_NAME)
1818
1919REGISTRY ?= nvcr.io/nvidia/cloud-native
2020
21- VERSION ?= v25.3.0
21+ # semver-compliant, i.e. w/o a v prefix
22+ VERSION ?= 25.3.0-rc.1
2223
2324# vVERSION represents the version with a guaranteed v-prefix
2425vVERSION := v$(VERSION:v%=% )
You can’t perform that action at this time.
0 commit comments