review: move start/stop

Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>

Author: jgehrcke

cmd/compute-domain-kubelet-plugin/cleanup.go

@@ -59,6 +59,37 @@ func NewCheckpointCleanupManager(s *DeviceState, client *draclient.Client) *Chec
 	}
 }
 
+func (m *CheckpointCleanupManager) Start(ctx context.Context, unprepfunc TypeUnprepCallable) error {
+	ctx, cancel := context.WithCancel(ctx)
+	m.cancelContext = cancel
+	m.unprepfunc = unprepfunc
+
+	m.waitGroup.Add(1)
+	go func() {
+		defer m.waitGroup.Done()
+		// Start producer: periodically submit cleanup task.
+		m.triggerPeriodically(ctx)
+	}()
+
+	m.waitGroup.Add(1)
+	go func() {
+		defer m.waitGroup.Done()
+		// Start consumer
+		m.worker(ctx)
+	}()
+
+	klog.V(6).Infof("CheckpointCleanupManager started")
+	return nil
+}
+
+func (m *CheckpointCleanupManager) Stop() error {
+	if m.cancelContext != nil {
+		m.cancelContext()
+	}
+	m.waitGroup.Wait()
+	return nil
+}
+
 // cleanup() is the high-level cleanup routine run once upon plugin startup and
 // then periodically. It gets all claims in PrepareStarted state from the
 // current checkpoint, and runs `unprepareIfStale()` for each of them. Each
@@ -186,37 +217,6 @@ func (m *CheckpointCleanupManager) getClaimByName(ctx context.Context, name stri
 	return claim, nil
 }
 
-func (m *CheckpointCleanupManager) Start(ctx context.Context, unprepfunc TypeUnprepCallable) error {
-	ctx, cancel := context.WithCancel(ctx)
-	m.cancelContext = cancel
-	m.unprepfunc = unprepfunc
-
-	m.waitGroup.Add(1)
-	go func() {
-		defer m.waitGroup.Done()
-		// Start producer: periodically submit cleanup task.
-		m.triggerPeriodically(ctx)
-	}()
-
-	m.waitGroup.Add(1)
-	go func() {
-		defer m.waitGroup.Done()
-		// Start consumer
-		m.worker(ctx)
-	}()
-
-	klog.V(6).Infof("CheckpointCleanupManager started")
-	return nil
-}
-
-func (m *CheckpointCleanupManager) Stop() error {
-	if m.cancelContext != nil {
-		m.cancelContext()
-	}
-	m.waitGroup.Wait()
-	return nil
-}
-
 // enqueueCleanup() submits a cleanup task if the queue is currently empty.
 // Return a Boolean indicating whether the task was submitted or not.
 func (m *CheckpointCleanupManager) enqueueCleanup() bool {