Break out of select/case, MkdirAll() before writing file

Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>

Author: jgehrcke

cmd/compute-domain-daemon/main.go

@@ -207,13 +207,11 @@ func run(ctx context.Context, cancel context.CancelFunc, flags *Flags) error {
 	// this node's state in the CD object.
 	if flags.cliqueID == "" {
 		klog.Infof("no cliqueID: register with ComputeDomain, but do not run IMEX daemon")
-	} else {
-		// Render and write the IMEX daemon config with the current pod IP. Only
-		// required when actually starting the IMEX daemon. Fails when
-		// /etc/nvidia-imex is not mounted in.
-		if err := writeIMEXConfig(flags.podIP); err != nil {
-			return fmt.Errorf("writeIMEXConfig failed: %w", err)
-		}
+	}
+
+	// Render and write the IMEX daemon config with the current pod IP
+	if err := writeIMEXConfig(flags.podIP); err != nil {
+		return fmt.Errorf("writeIMEXConfig failed: %w", err)
 	}
 
 	// Prepare IMEX daemon process manager (not invoking the process yet).
@@ -308,7 +306,7 @@ func IMEXDaemonUpdateLoopWithIPs(ctx context.Context, controller *Controller, cl
 
 			if cliqueID == "" {
 				klog.V(1).Infof("empty cliqueID: do not start IMEX daemon")
-				continue
+				break
 			}
 
 			klog.Infof("Got update, (re)start IMEX daemon")
@@ -342,7 +340,7 @@ func IMEXDaemonUpdateLoopWithDNSNames(ctx context.Context, controller *Controlle
 
 			if dnsNameManager.cliqueID == "" {
 				klog.V(1).Infof("empty cliqueID: do not start IMEX daemon")
-				continue
+				break
 			}
 
 			fresh, err := processManager.EnsureStarted()
@@ -358,7 +356,7 @@ func IMEXDaemonUpdateLoopWithDNSNames(ctx context.Context, controller *Controlle
 			// addresses compared to the old set (then we don't need to force
 			// the daemon to re-resolve & re-connect).
 			if !updated || fresh {
-				continue
+				break
 			}
 
 			// Actively ask the IMEX daemon to re-read its config and to
@@ -419,6 +417,12 @@ func writeIMEXConfig(podIP string) error {
 		return fmt.Errorf("error executing template: %w", err)
 	}
 
+	// Ensure the directory exists
+	dir := filepath.Dir(imexConfigPath)
+	if err := os.MkdirAll(dir, 0755); err != nil {
+		return fmt.Errorf("failed to create directory %s: %w", dir, err)
+	}
+
 	if err := os.WriteFile(imexConfigPath, configFile.Bytes(), 0644); err != nil {
 		return fmt.Errorf("error writing config file %v: %w", imexConfigPath, err)
 	}