Skip to content

Commit 285e55c

Browse files
committed
Sort UUIDs of prepared and allocatable devices for comparisons
Signed-off-by: Kevin Klues <[email protected]>
1 parent 6602179 commit 285e55c

File tree

2 files changed

+22
-4
lines changed

2 files changed

+22
-4
lines changed

cmd/nvidia-dra-plugin/allocatable.go

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
package main
1818

1919
import (
20+
"slices"
21+
2022
resourceapi "k8s.io/api/resource/v1alpha3"
2123
)
2224

@@ -84,6 +86,7 @@ func (d AllocatableDevices) GpuUUIDs() []string {
8486
uuids = append(uuids, device.Gpu.UUID)
8587
}
8688
}
89+
slices.Sort(uuids)
8790
return uuids
8891
}
8992

@@ -94,9 +97,12 @@ func (d AllocatableDevices) MigDeviceUUIDs() []string {
9497
uuids = append(uuids, device.Mig.UUID)
9598
}
9699
}
100+
slices.Sort(uuids)
97101
return uuids
98102
}
99103

100104
func (d AllocatableDevices) UUIDs() []string {
101-
return append(d.GpuUUIDs(), d.MigDeviceUUIDs()...)
105+
uuids := append(d.GpuUUIDs(), d.MigDeviceUUIDs()...)
106+
slices.Sort(uuids)
107+
return uuids
102108
}

cmd/nvidia-dra-plugin/prepared.go

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
package main
1818

1919
import (
20+
"slices"
21+
2022
drapbv1 "k8s.io/kubelet/pkg/apis/dra/v1alpha4"
2123
)
2224

@@ -141,22 +143,29 @@ func (g *PreparedDeviceGroup) GetDevices() []*drapbv1.Device {
141143
}
142144

143145
func (l PreparedDeviceList) UUIDs() []string {
144-
return append(l.GpuUUIDs(), l.MigDeviceUUIDs()...)
146+
uuids := append(l.GpuUUIDs(), l.MigDeviceUUIDs()...)
147+
slices.Sort(uuids)
148+
return uuids
145149
}
146150

147151
func (g *PreparedDeviceGroup) UUIDs() []string {
148-
return append(g.GpuUUIDs(), g.MigDeviceUUIDs()...)
152+
uuids := append(g.GpuUUIDs(), g.MigDeviceUUIDs()...)
153+
slices.Sort(uuids)
154+
return uuids
149155
}
150156

151157
func (d PreparedDevices) UUIDs() []string {
152-
return append(d.GpuUUIDs(), d.MigDeviceUUIDs()...)
158+
uuids := append(d.GpuUUIDs(), d.MigDeviceUUIDs()...)
159+
slices.Sort(uuids)
160+
return uuids
153161
}
154162

155163
func (l PreparedDeviceList) GpuUUIDs() []string {
156164
var uuids []string
157165
for _, device := range l.Gpus() {
158166
uuids = append(uuids, device.Gpu.Info.UUID)
159167
}
168+
slices.Sort(uuids)
160169
return uuids
161170
}
162171

@@ -169,6 +178,7 @@ func (d PreparedDevices) GpuUUIDs() []string {
169178
for _, group := range d {
170179
uuids = append(uuids, group.GpuUUIDs()...)
171180
}
181+
slices.Sort(uuids)
172182
return uuids
173183
}
174184

@@ -177,6 +187,7 @@ func (l PreparedDeviceList) MigDeviceUUIDs() []string {
177187
for _, device := range l.MigDevices() {
178188
uuids = append(uuids, device.Mig.Info.UUID)
179189
}
190+
slices.Sort(uuids)
180191
return uuids
181192
}
182193

@@ -189,5 +200,6 @@ func (d PreparedDevices) MigDeviceUUIDs() []string {
189200
for _, group := range d {
190201
uuids = append(uuids, group.MigDeviceUUIDs()...)
191202
}
203+
slices.Sort(uuids)
192204
return uuids
193205
}

0 commit comments

Comments
 (0)