Deep-copy CD object only when mutation needed

Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>

Author: jgehrcke

cmd/compute-domain-daemon/computedomain.go

@@ -220,19 +220,11 @@ func (m *ComputeDomainManager) onAddOrUpdate(ctx context.Context, obj any) error
 func (m *ComputeDomainManager) UpdateComputeDomainNodeInfo(ctx context.Context, cd *nvapi.ComputeDomain) (rerr error) {
 	var nodeInfo *nvapi.ComputeDomainNode
 
-	// Create a deep copy of the ComputeDomain to avoid modifying the original
-	newCD := cd.DeepCopy()
-
-	defer func() {
-		if rerr == nil {
-			m.MaybePushNodesUpdate(newCD)
-		}
-	}()
-
 	// Try to find an existing entry for the current k8s node
-	for _, node := range newCD.Status.Nodes {
+	for _, node := range cd.Status.Nodes {
 		if node.Name == m.config.nodeName {
-			nodeInfo = node
+			// Create copy because we may mutate it below.
+			nodeInfo = node.DeepCopy()
 			break
 		}
 	}
@@ -242,6 +234,15 @@ func (m *ComputeDomainManager) UpdateComputeDomainNodeInfo(ctx context.Context,
 		return nil
 	}
 
+	// Create a deep copy of the ComputeDomain to avoid modifying the original
+	newCD := cd.DeepCopy()
+
+	defer func() {
+		if rerr == nil {
+			m.MaybePushNodesUpdate(newCD)
+		}
+	}()
+
 	// If there isn't one, create one and append it to the list
 	if nodeInfo == nil {
 		// Get the next available index for this new node