Skip to content

Commit 03d2a95

Browse files
committed
polish
Signed-off-by: Dr. Jan-Philip Gehrcke <[email protected]>
1 parent aa0945c commit 03d2a95

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

deployments/helm/nvidia-dra-driver-gpu/templates/kubeletplugin.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,8 @@ spec:
5454
image: {{ include "nvidia-dra-driver-gpu.fullimage" . }}
5555
securityContext:
5656
privileged: true
57-
# Bashisms are used below. Feed logic from stdin: the shell script file
58-
# path does not exist after chroot
57+
# Bashisms are used in kubelet-plugin-prestart.sh. Feed logic from
58+
# stdin: script path does not exist in chroot environment.
5959
command: [sh, "-c", "chroot /driver-root bash -s < /usr/bin/kubelet-plugin-prestart.sh"]
6060
env:
6161
- name: NVIDIA_DRIVER_ROOT

hack/kubelet-plugin-prestart.sh

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,9 @@
44
# properly before installing this DRA driver. In that case, the log of the init
55
# container running this script is meant to yield an actionable error message.
66
#
7-
# Executed in a long-running init container.
8-
#
9-
# Crash-loop (retry periodically) and actively wait for the GPU driver to be set
10-
# up properly (unblock the DRA driver plugin daemonset pods from progressing
11-
# right after the GPU driver setup has been fixed).
7+
# Crash-loop (retry periodically) and actively wait for the GPU driver to come
8+
# online (unblock the DRA driver plugin daemonset pods from progressing right
9+
# after the GPU driver setup has been fixed).
1210

1311
if [ -z "$NVIDIA_DRIVER_ROOT" ]; then
1412
# Not set, or set to empty string (not distinguishable).
@@ -18,9 +16,9 @@ fi
1816

1917
echo "NVIDIA_DRIVER_ROOT (path on host): ${NVIDIA_DRIVER_ROOT}"
2018

21-
# Note: the following path is in-container, after chroot to
22-
# /driver-root (and /driver-root is where NVIDIA_DRIVER_ROOT is
23-
# mounted from the host filesystem).
19+
# Note: the following path is in-container, after chroot to /driver-root (and
20+
# /driver-root is where NVIDIA_DRIVER_ROOT is mounted from the host filesystem).
21+
# This typically outputs /usr/bin/nvidia-smi.
2422
echo "command -v nvidia-smi: $(command -v nvidia-smi)"
2523

2624
while true

0 commit comments

Comments
 (0)