TOFIX: code scanning

Signed-off-by: Evan Lezar <[email protected]>

Author: elezar

.github/workflows/basic-checks.yaml

@@ -36,6 +36,8 @@ jobs:
       golang_version: ${{ needs.variables.outputs.golang_version }}
 
   code-scanning:
+    needs:
+    - variables
     uses: ./.github/workflows/code_scanning.yaml
     with:
       golang_version: ${{ needs.variables.outputs.golang_version }}

.github/workflows/code_scanning.yaml

@@ -20,43 +20,9 @@ on:
       golang_version:
         required: true
         type: string
-  pull_request:
-    types:
-      - opened
-      - synchronize
-    branches:
-      - main
-      - release-*
-
 
 jobs:
-  # TODO: Is there a way that we can only invoke this if this is a PR?
-  optionalVariables:
-    if: ${{ github.event_name == 'pull_request' }}
-    uses: ./.github/workflows/variables.yaml
-
-  variables:
-    runs-on: ubuntu-latest
-    needs:
-    - optionalVariables
-    if: always()
-    outputs:
-      golang_version: ${{ steps.golang_output.outputs.golang_version }}
-    steps:
-    - name: Check out code
-      uses: actions/checkout@v4
-    - id: golang_version
-      run: |
-        if [[ "${{ github.event_name }}" == "pull_request" ]]; then
-          GOLANG_VERSION="${{ needs.optionalVariables.output.golang_version }}"
-        else
-          GOLANG_VERSION="${{ inputs.golang_version}}"
-        fi
-        echo "golang_version=${GOLANG_VERSION##GOLANG_VERSION ?= }" >> $GITHUB_OUTPUT
-
   analyze:
-    needs:
-    - variables
     name: Analyze Go code with CodeQL
     if: always()
     runs-on: ubuntu-latest
@@ -71,7 +37,7 @@ jobs:
     - name: Install Go
       uses: actions/setup-go@v5
       with:
-        go-version: ${{ needs.variables.outputs.golang_version }}
+        go-version: ${{ inputs.golang_version }}
 
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3

.github/workflows/e2e.yaml

@@ -74,7 +74,7 @@ jobs:
 
     - name: Send Slack alert notification
       id: slack
-      if: ${{ failure() }}
+      if: false
       uses: slackapi/[email protected]
       env:
         SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}