[no-relnote] Fix copylocks: use pointer receivers and avoid Device struct copies

Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>

Author: ArangoGutierrez

internal/rm/device_map.go

@@ -23,6 +23,7 @@ import (
 	"github.com/NVIDIA/go-nvlib/pkg/nvlib/info"
 	"github.com/NVIDIA/go-nvml/pkg/nvml"
 	"k8s.io/klog/v2"
+	pluginapi "k8s.io/kubelet/pkg/apis/deviceplugin/v1beta1"
 
 	spec "github.com/NVIDIA/k8s-device-plugin/api/config/v1"
 )
@@ -324,9 +325,19 @@ func updateDeviceMapWithReplicas(replicatedResources *spec.ReplicatedResources,
 		for _, id := range ids {
 			for i := 0; i < r.Replicas; i++ {
 				annotatedID := string(NewAnnotatedID(id, i))
-				replicatedDevice := *(oDevices[r.Name][id])
-				replicatedDevice.ID = annotatedID
-				replicatedDevice.Replicas = r.Replicas
+				original := oDevices[r.Name][id]
+				replicatedDevice := Device{
+					Device: pluginapi.Device{
+						ID:       annotatedID,
+						Health:   original.Health,
+						Topology: original.Topology,
+					},
+					Paths:             original.Paths,
+					Index:             original.Index,
+					TotalMemory:       original.TotalMemory,
+					ComputeCapability: original.ComputeCapability,
+					Replicas:          r.Replicas,
+				}
 				devices.insert(name, &replicatedDevice)
 			}
 		}

internal/rm/devices.go

@@ -213,8 +213,9 @@ func (ds Devices) AlignedAllocationSupported() bool {
 	return true
 }
 
-// AlignedAllocationSupported checks whether the device supports an aligned allocation
-func (d Device) AlignedAllocationSupported() bool {
+// AlignedAllocationSupported checks whether the device supports an aligned
+// allocation
+func (d *Device) AlignedAllocationSupported() bool {
 	if d.IsMigDevice() {
 		return false
 	}
@@ -229,12 +230,12 @@ func (d Device) AlignedAllocationSupported() bool {
 }
 
 // IsMigDevice returns checks whether d is a MIG device or not.
-func (d Device) IsMigDevice() bool {
+func (d *Device) IsMigDevice() bool {
 	return strings.Contains(d.Index, ":")
 }
 
 // GetUUID returns the UUID for the device from the annotated ID.
-func (d Device) GetUUID() string {
+func (d *Device) GetUUID() string {
 	return AnnotatedID(d.ID).GetID()
 }