Tag bundle image with current commit sha #1898
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivakunv
force-pushed
the
bundlecommitsha
branch
from
6c0f9bb to
3575140
Compare
Signed-off-by: Shiva Kumar (SW-CLOUD) <[email protected]>
shivakunv
force-pushed
the
bundlecommitsha
branch
from
2411206 to
076614c
Compare
Contributor
Author
|
passed pipeline: https://github.com/NVIDIA/gpu-operator/actions/runs/19452460548 |
shivakunv
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
shivakunv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the GPU Operator image configured in the bundle is ghcr.io/nvidia/gpu-operator:main-latest (see here). This can be problematic for two reasons. First, it is difficult to deduce which commit SHA the operator image / OLM bundle was built from. Therefore, it is difficult to infer which commit SHA introduced a test failure. Second, the gpu-operator deployment runs with
imagePullPolicy=IfNotPresentby default. This means if the gpu-operator image (with the main-latest) tag is already cached on the node, the latest image may not be pulled / tested. To address these shortcomings, we should generate an OLM bundle that is using SHA-tagged images of gpu-operator.We should update the GitHub Actions job that builds + pushes an OLM bundle image as follows:
Before building the bundle image, it should update all gpu-operator image tags in the CSV file to refer to the commit SHA. E.g. ghcr.io/nvidia/gpu-operator:
When pushing the OLM bundle image, we should push two tags – one tag will be main-latest and the other will be