Skip to content

Commit 20b54f7

Browse files
authored
Merge pull request #1019 from NVIDIA/nv-ctk-envars
set RUNTIME_CONFIG and RUNTIME_SOCKET envars to support new toolkit versions
2 parents c94a154 + 2282a70 commit 20b54f7

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

controllers/object_controls.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1291,6 +1291,7 @@ func transformForRuntime(obj *appsv1.DaemonSet, config *gpuv1.ClusterPolicySpec,
12911291
configEnvvarName = "CRIO_CONFIG"
12921292
}
12931293

1294+
setContainerEnv(mainContainer, "RUNTIME_CONFIG", DefaultRuntimeConfigTargetDir+sourceConfigFileName)
12941295
setContainerEnv(mainContainer, configEnvvarName, DefaultRuntimeConfigTargetDir+sourceConfigFileName)
12951296

12961297
volMountConfigName := fmt.Sprintf("%s-config", runtime)
@@ -1314,6 +1315,7 @@ func transformForRuntime(obj *appsv1.DaemonSet, config *gpuv1.ClusterPolicySpec,
13141315
} else if runtime == gpuv1.Docker.String() {
13151316
socketEnvvarName = "DOCKER_SOCKET"
13161317
}
1318+
setContainerEnv(mainContainer, "RUNTIME_SOCKET", DefaultRuntimeSocketTargetDir+sourceSocketFileName)
13171319
setContainerEnv(mainContainer, socketEnvvarName, DefaultRuntimeSocketTargetDir+sourceSocketFileName)
13181320

13191321
volMountSocketName := fmt.Sprintf("%s-socket", runtime)

controllers/transforms_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,9 @@ func TestTransformForRuntime(t *testing.T) {
302302
Env: []corev1.EnvVar{
303303
{Name: "RUNTIME", Value: gpuv1.Containerd.String()},
304304
{Name: "CONTAINERD_RUNTIME_CLASS", Value: DefaultRuntimeClass},
305+
{Name: "RUNTIME_CONFIG", Value: filepath.Join(DefaultRuntimeConfigTargetDir, filepath.Base(DefaultContainerdConfigFile))},
305306
{Name: "CONTAINERD_CONFIG", Value: filepath.Join(DefaultRuntimeConfigTargetDir, filepath.Base(DefaultContainerdConfigFile))},
307+
{Name: "RUNTIME_SOCKET", Value: filepath.Join(DefaultRuntimeSocketTargetDir, filepath.Base(DefaultContainerdSocketFile))},
306308
{Name: "CONTAINERD_SOCKET", Value: filepath.Join(DefaultRuntimeSocketTargetDir, filepath.Base(DefaultContainerdSocketFile))},
307309
},
308310
VolumeMounts: []corev1.VolumeMount{
@@ -321,6 +323,7 @@ func TestTransformForRuntime(t *testing.T) {
321323
Name: "test-ctr",
322324
Env: []corev1.EnvVar{
323325
{Name: "RUNTIME", Value: gpuv1.CRIO.String()},
326+
{Name: "RUNTIME_CONFIG", Value: filepath.Join(DefaultRuntimeConfigTargetDir, filepath.Base(DefaultCRIOConfigFile))},
324327
{Name: "CRIO_CONFIG", Value: filepath.Join(DefaultRuntimeConfigTargetDir, filepath.Base(DefaultCRIOConfigFile))},
325328
},
326329
VolumeMounts: []corev1.VolumeMount{

0 commit comments

Comments
 (0)