Skip to content

Commit f01fd28

Browse files
committed
pass golang version as docker build arg and bump version to 1.22.8
Signed-off-by: Tariq Ibrahim <[email protected]>
1 parent f547761 commit f01fd28

File tree

6 files changed

+8
-8
lines changed

6 files changed

+8
-8
lines changed

Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,7 @@ $(DRIVER_BUILD_TARGETS):
149149
$(DOCKER_BUILD_PLATFORM_OPTIONS) \
150150
--tag $(IMAGE) \
151151
--build-arg DRIVER_VERSION="$(DRIVER_VERSION)" \
152+
--build-arg GOLANG_VERSION="$(GOLANG_VERSION)" \
152153
--build-arg DRIVER_BRANCH="$(DRIVER_BRANCH)" \
153154
--build-arg CUDA_VERSION="$(CUDA_VERSION)" \
154155
--build-arg CVE_UPDATES="$(CVE_UPDATES)" \
@@ -186,6 +187,7 @@ $(BASE_BUILD_TARGETS):
186187
--tag $(IMAGE) \
187188
--target $(TARGET) \
188189
--build-arg CUDA_VERSION="$(CUDA_VERSION)" \
190+
--build-arg GOLANG_VERSION="$(GOLANG_VERSION)" \
189191
--build-arg DRIVER_BRANCH="$(DRIVER_BRANCH)" \
190192
--build-arg KERNEL_FLAVOR="$(KERNEL_FLAVOR)" \
191193
--file $(DOCKERFILE) \

rhel8/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ SHELL ["/bin/bash", "-c"]
66

77
RUN dnf install -y git wget
88

9-
ENV GOLANG_VERSION=1.22.7
10-
119
# download appropriate binary based on the target architecture for multi-arch builds
1210
RUN OS_ARCH=${TARGETARCH/x86_64/amd64} && OS_ARCH=${OS_ARCH/aarch64/arm64} && \
1311
curl https://storage.googleapis.com/golang/go${GOLANG_VERSION}.linux-${OS_ARCH}.tar.gz \
@@ -33,6 +31,7 @@ SHELL ["/bin/bash", "-c"]
3331
ARG BASE_URL=https://us.download.nvidia.com/tesla
3432
ARG DRIVER_VERSION
3533
ENV DRIVER_VERSION=$DRIVER_VERSION
34+
ARG GOLANG_VERSION
3635

3736
# Arg to indicate if driver type is either of passthrough/baremetal or vgpu
3837
ARG DRIVER_TYPE=passthrough

rhel9/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ SHELL ["/bin/bash", "-c"]
66

77
RUN dnf install -y git wget
88

9-
ENV GOLANG_VERSION=1.22.7
10-
119
# download appropriate binary based on the target architecture for multi-arch builds
1210
RUN OS_ARCH=${TARGETARCH/x86_64/amd64} && OS_ARCH=${OS_ARCH/aarch64/arm64} && \
1311
curl https://storage.googleapis.com/golang/go${GOLANG_VERSION}.linux-${OS_ARCH}.tar.gz \
@@ -33,6 +31,7 @@ SHELL ["/bin/bash", "-c"]
3331
ARG BASE_URL=https://us.download.nvidia.com/tesla
3432
ARG DRIVER_VERSION
3533
ENV DRIVER_VERSION=$DRIVER_VERSION
34+
ARG GOLANG_VERSION
3635

3736
# Arg to indicate if driver type is either of passthrough/baremetal or vgpu
3837
ARG DRIVER_TYPE=passthrough

ubuntu20.04/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
1717
git && \
1818
rm -rf /var/lib/apt/lists/*
1919

20-
ENV GOLANG_VERSION=1.22.7
21-
2220
# download appropriate binary based on the target architecture for multi-arch builds
2321
RUN OS_ARCH=${TARGETARCH/x86_64/amd64} && OS_ARCH=${OS_ARCH/aarch64/arm64} && \
2422
curl https://storage.googleapis.com/golang/go${GOLANG_VERSION}.linux-${OS_ARCH}.tar.gz \
@@ -41,6 +39,7 @@ ARG BASE_URL=https://us.download.nvidia.com/tesla
4139
ARG TARGETARCH
4240
ENV TARGETARCH=$TARGETARCH
4341
ARG DRIVER_VERSION
42+
ARG GOLANG_VERSION
4443
ENV DRIVER_VERSION=$DRIVER_VERSION
4544
ENV DEBIAN_FRONTEND=noninteractive
4645

ubuntu22.04/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
1717
git && \
1818
rm -rf /var/lib/apt/lists/*
1919

20-
ENV GOLANG_VERSION=1.22.7
21-
2220
# download appropriate binary based on the target architecture for multi-arch builds
2321
RUN OS_ARCH=${TARGETARCH/x86_64/amd64} && OS_ARCH=${OS_ARCH/aarch64/arm64} && \
2422
curl https://storage.googleapis.com/golang/go${GOLANG_VERSION}.linux-${OS_ARCH}.tar.gz \
@@ -41,6 +39,7 @@ ARG BASE_URL=https://us.download.nvidia.com/tesla
4139
ARG TARGETARCH
4240
ENV TARGETARCH=$TARGETARCH
4341
ARG DRIVER_VERSION
42+
ARG GOLANG_VERSION
4443
ENV DRIVER_VERSION=$DRIVER_VERSION
4544
ENV DEBIAN_FRONTEND=noninteractive
4645

versions.mk

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,5 @@
1616
DRIVER_VERSIONS ?= 535.183.06 550.90.12 560.35.03
1717

1818
CUDA_VERSION := 12.6.0
19+
20+
GOLANG_VERSION := 1.22.8

0 commit comments

Comments
 (0)