Skip to content

Commit b92716b

Browse files
committed
Test Not for review holodeck kernel version change
1 parent 8a313b5 commit b92716b

File tree

8 files changed

+25
-100
lines changed

8 files changed

+25
-100
lines changed

.github/workflows/image.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ on:
2121
- opened
2222
- synchronize
2323
branches:
24-
- main
25-
- release-*
24+
- main-no
25+
- release-no
2626
push:
2727
branches:
28-
- main
29-
- release-*
28+
- main-no
29+
- release-no
3030

3131
jobs:
3232
image:

.github/workflows/precompiled.yaml

Lines changed: 16 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,15 @@
1616
name: Precompiled images
1717

1818
on:
19-
schedule:
20-
- cron: '00 09 * * *'
19+
pull_request:
20+
types:
21+
- opened
22+
- synchronize
23+
branches:
24+
- test-holodeck
25+
push:
26+
branches:
27+
- test-holodeck
2128

2229
jobs:
2330
set-driver-version-matrix:
@@ -39,17 +46,20 @@ jobs:
3946
echo "driver_branch=$driver_branch_json" >> $GITHUB_OUTPUT
4047
4148
# get kernel flavors
42-
KERNEL_FLAVORS=("aws" "azure" "generic" "nvidia" "oracle")
49+
# KERNEL_FLAVORS=("aws" "azure" "generic" "nvidia" "oracle")
50+
KERNEL_FLAVORS=("generic")
4351
kernel_flavors_json=$(printf '%s\n' "${KERNEL_FLAVORS[@]}" | jq -R . | jq -cs .)
4452
echo "kernel_flavors=$kernel_flavors_json" >> $GITHUB_OUTPUT
4553
4654
# get ubuntu distributions
47-
DIST=("ubuntu22.04" "ubuntu24.04")
55+
# DIST=("ubuntu22.04" "ubuntu24.04")
56+
DIST=("ubuntu22.04")
4857
dist_json=$(printf '%s\n' "${DIST[@]}" | jq -R . | jq -cs .)
4958
echo "dist=$dist_json" >> $GITHUB_OUTPUT
5059
5160
# LTS_KERNEL setup
52-
LTS_KERNEL=("5.15" "6.8")
61+
# LTS_KERNEL=("5.15" "6.8")
62+
LTS_KERNEL=("6.8")
5363
lts_kernel_json=$(printf '%s\n' "${LTS_KERNEL[@]}" | jq -R . | jq -cs .)
5464
echo "lts_kernel=$lts_kernel_json" >> $GITHUB_OUTPUT
5565
@@ -321,7 +331,7 @@ jobs:
321331
echo "DRIVER_BRANCHES=${DRIVER_BRANCHES[*]}" >> $GITHUB_ENV
322332
323333
- name: Set up Holodeck
324-
uses: NVIDIA/holodeck@v0.2.6
334+
uses: NVIDIA/holodeck@main
325335
env:
326336
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
327337
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
@@ -346,27 +356,6 @@ jobs:
346356
sudo apt-get update
347357
sudo apt-get install -y gh
348358
349-
- name: Upgrade the kernel for Precompiled e2e test
350-
env:
351-
UPGRADE_KERNEL_SCRIPT: "./tests/scripts/upgrade-kernel.sh"
352-
run: |
353-
status=0
354-
./tests/ci-remote-exec.sh "${UPGRADE_KERNEL_SCRIPT}" "${KERNEL_VERSION}" || status=$?
355-
# On the target system, all scripts/test-case exit with code 1 for error handling.
356-
# However, since reboot-related disconnections break the SSH connection
357-
# and can cause the entire job to exit, we should ignore all errors except
358-
# exit code 1. During a reboot, exit code 1 will not be thrown, so handling
359-
# other errors as code 1 will ensure proper management of reboot scenarios
360-
if [ $status -eq 1 ]; then
361-
echo "Kernel version $KERNEL_VERSION upgrade failed"
362-
exit 1
363-
fi
364-
./tests/scripts/remote_retry.sh || status=$?
365-
if [ $status -ne 0 ]; then
366-
echo "Failed to connect to remote instance"
367-
exit $status
368-
fi
369-
370359
- name: Precompiled e2e test gpu driver validation
371360
env:
372361
TEST_CASE: "./tests/cases/nvidia-driver.sh"

tests/holodeck_ubuntu22.04.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,5 @@ spec:
3232
installer: kubeadm
3333
version: v1.28.5
3434
crictlVersion: v1.28.0
35+
kernel:
36+
version: 5.15.0-139-generic

tests/holodeck_ubuntu24.04.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,3 +33,5 @@ spec:
3333
installer: kubeadm
3434
version: v1.30.0
3535
crictlVersion: v1.30.0
36+
kernel:
37+
version: 6.8.0-59-generic

tests/scripts/.definitions.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ CASES_DIR="$( cd "${TEST_DIR}/cases" && pwd )"
1616

1717
: ${HELM_NVIDIA_REPO:="https://helm.ngc.nvidia.com/nvidia"}
1818

19-
: ${DAEMON_POD_STATUS_TIME_OUT:="15m"}
2019
: ${POD_STATUS_TIME_OUT:="2m"}
2120

2221
: ${LOG_DIR:="/tmp/logs"}

tests/scripts/findkernelversion.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,3 +42,4 @@ if [[ $status_nvcr -eq 0 || $status_ghcr -eq 0 ]]; then
4242
else
4343
export should_continue=true
4444
fi
45+
export should_continue=true

tests/scripts/kernel-upgrade-helper.sh

Lines changed: 0 additions & 54 deletions
This file was deleted.

tests/scripts/upgrade-kernel.sh

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)