* Addressing review comments

Signed-off-by: Pradnya Khalate <[email protected]>

Author: khalatepradnya

include/cudaq/Optimizer/CodeGen/Passes.td

@@ -139,7 +139,6 @@ def QirInsertArrayRecord : Pass<"qir-insert-array-record", "mlir::ModuleOp"> {
   }];
   let dependentDialects = ["quake::QuakeDialect", "cudaq::cc::CCDialect", 
       "mlir::LLVM::LLVMDialect"];
-  let constructor = "cudaq::opt::createQirInsertArrayRecord()";
 }
 
 def RemoveMeasurements : Pass<"remove-measurements"> {

lib/Optimizer/CodeGen/QirInsertArrayRecord.cpp

@@ -189,31 +189,25 @@ struct QirInsertArrayRecordPass
 
   void runOnOperation() override {
     ModuleOp module = getOperation();
-    module.walk([&](func::FuncOp funcOp) {
+    for (auto funcOp : module.getOps<func::FuncOp>()) {
       if (!funcOp || funcOp.empty() ||
           !funcOp->hasAttr(cudaq::entryPointAttrName) ||
           funcOp->hasAttr(cudaq::runtime::enableCudaqRun))
-        return WalkResult::advance();
+        continue;
 
       AllocaMeasureStoreAnalysis analysis(funcOp);
       if (analysis.arraySize == 0)
-        return WalkResult::advance();
+        continue;
 
       LLVM_DEBUG(llvm::dbgs() << "Before adding array recording call:\n"
                               << *funcOp);
       if (failed(insertArrayRecordingCalls(funcOp, analysis.arraySize,
                                            analysis.allocaOps,
                                            analysis.firstMeasurementOp)))
-        return WalkResult::interrupt();
+        return signalPassFailure();
       LLVM_DEBUG(llvm::dbgs() << "After adding array recording call:\n"
                               << *funcOp);
-
-      return WalkResult::advance();
-    });
+    }
   }
 };
 } // namespace
-
-std::unique_ptr<Pass> cudaq::opt::createQirInsertArrayRecord() {
-  return std::make_unique<QirInsertArrayRecordPass>();
-}