Adding venv and fixing regex (#3610)

* adding venv and fix regex

Signed-off-by: Sachin Pisal <[email protected]>

* adding sudo

Signed-off-by: Sachin Pisal <[email protected]>

* reverting regex

Signed-off-by: Sachin Pisal <[email protected]>

* fixing the regex

Signed-off-by: Sachin Pisal <[email protected]>

* capturing single quotes in regex

Signed-off-by: Sachin Pisal <[email protected]>

* capture only the target

Signed-off-by: Sachin Pisal <[email protected]>

* fix regex

Signed-off-by: Sachin Pisal <[email protected]>

* fixing the regex to combine the target and option as a valid backend

Signed-off-by: Sachin Pisal <[email protected]>

* adding escape for #

Signed-off-by: Sachin Pisal <[email protected]>

* format

Signed-off-by: Sachin Pisal <[email protected]>

* simplifying the condition

Signed-off-by: Sachin Pisal <[email protected]>

* updating torch version

Signed-off-by: Sachin Pisal <[email protected]>

* Adding pattern matching examples and fetching only the target, ignoring option

Signed-off-by: Sachin Pisal <[email protected]>

* updating python3-venv

Signed-off-by: Sachin Pisal <[email protected]>

* making spellchecker happy

Signed-off-by: Sachin Pisal <[email protected]>

* skipping logical_aim_sqale and updating pip install for hqnn

Signed-off-by: Sachin Pisal <[email protected]>

* format

Signed-off-by: Sachin Pisal <[email protected]>

---------

Signed-off-by: Sachin Pisal <[email protected]>

Author: sacpis

.github/workflows/docker_images.yml

@@ -841,6 +841,7 @@ jobs:
           # In containers without GPU support, UCX does not work properly since it is configured to work with GPU-support.
           # Hence, don't enforce UCX when running these tests.
           docker exec cuda-quantum bash -c "python3 -m pip install --break-system-packages pandas scipy seaborn h5py contfrac"
+          docker exec cuda-quantum bash -c "sudo apt install -y python3-venv"
           (docker exec cuda-quantum bash -c "unset OMPI_MCA_pml && set -o pipefail && bash validate_container.sh | tee /tmp/validation.out") && passed=true || passed=false
           docker cp cuda-quantum:"/tmp/validation.out" /tmp/validation.out
           docker stop cuda-quantum

docs/notebook_validation.py

@@ -25,13 +25,33 @@ def read_available_backends():
     return [backend.strip() for backend in available_backends]
 
 
+# Following pattern matches
+# `set_target("abc")`
+# `set_target( "abc")`
+# `set_target("abc", option="xyz")`
+# `set_target("abc", option = "xyz")`
+# `set_target(\"abc\")`
+# `set_target( \"abc\")`
+# `set_target(\"abc\", option=\"xyz\")`
+# `set_target(\"abc\", option = \"xyz\")`
+# `set_target('abc')`
+# `set_target( 'abc')`
+# `set_target('abc', option='xyz')`
+# `set_target('abc', option = 'xyz')`
+pattern = r"set_target\(\s*(\\?['\"])([^'\"]+)\1(?:\s*,\s*option\s*=\s*(\\?['\"])([^'\"]+)\3)?\)"
+
+
 def validate(notebook_filename, available_backends):
     with open(notebook_filename) as f:
         lines = f.readlines()
     for notebook_content in lines:
-        match = re.search('set_target[\\\s\(]+"(.+)\\\\"[)]', notebook_content)
-        if match and (match.group(1) not in available_backends):
-            return False
+        if re.search(r'\s*\#', notebook_content):
+            continue
+
+        match = re.search(pattern, notebook_content)
+        if match:
+            target = match.group(2)
+            return target in available_backends
     for notebook_content in lines:
         match = re.search('--target ([^ ]+)', notebook_content)
         if match and (match.group(1) not in available_backends):
@@ -122,7 +142,9 @@ def print_results(success, failed, skipped=[]):
 
         ## `quantum_transformer`:
         ## See: https://github.com/NVIDIA/cuda-quantum/issues/2689
-        notebooks_skipped = ['quantum_transformer.ipynb']
+        notebooks_skipped = [
+            'quantum_transformer.ipynb', 'logical_aim_sqale.ipynb'
+        ]
 
         for notebook_filename in notebook_filenames:
             base_name = os.path.basename(notebook_filename)