Skip to content

Commit ffe9f98

Browse files
Apply suggestions from code review
Co-authored-by: Daniel Jünger <[email protected]>
1 parent 8ef8d1f commit ffe9f98

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

include/cuco/detail/roaring_bitmap/roaring_bitmap_storage.cuh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class roaring_bitmap_storage_ref<cuda::std::uint32_t> {
5252
/**
5353
* @brief Constructs a storage reference from bitmap data and metadata
5454
*
55-
* @param bitmap Pointer to the serialized bitmap data
55+
* @param bitmap Pointer to the serialized bitmap in a device-accessible memory location
5656
* @param metadata Metadata describing the bitmap structure
5757
*/
5858
__host__ __device__ roaring_bitmap_storage_ref(cuda::std::byte const* bitmap,
@@ -71,7 +71,7 @@ class roaring_bitmap_storage_ref<cuda::std::uint32_t> {
7171
*
7272
* Automatically parses metadata from the bitmap data.
7373
*
74-
* @param bitmap Pointer to the serialized bitmap data
74+
* @param bitmap Pointer to the serialized bitmap in a device-accessible memory location
7575
*/
7676
__device__ roaring_bitmap_storage_ref(cuda::std::byte const* bitmap)
7777
: roaring_bitmap_storage_ref{bitmap, metadata_type{bitmap}}
@@ -149,9 +149,9 @@ class roaring_bitmap_storage_ref<cuda::std::uint64_t> {
149149
/**
150150
* @brief Constructs a storage reference from bitmap data, metadata, and buckets
151151
*
152-
* @param bitmap Pointer to the serialized bitmap data
152+
* @param bitmap Pointer to the serialized bitmap in a device-accessible memory location
153153
* @param metadata Metadata describing the bitmap structure
154-
* @param buckets Pointer to the array of bucket references
154+
* @param buckets Pointer to the array of bucket references in a device-accessible memory location
155155
*/
156156
__host__ __device__ roaring_bitmap_storage_ref(
157157
cuda::std::byte const* bitmap,

include/cuco/operator.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ struct find_tag {
317317
* @see @tparam OutputProbeIt Device accessible input iterator whose `value_type` is
318318
* convertible to the container's `key_type`
319319
* @see @tparam OutputMatchIt Device accessible input iterator whose `value_type` is
320-
* convertible to the container's value_type
320+
* convertible to the container's `value_type`
321321
* @see @tparam AtomicCounter Atomic counter type that follows the same semantics as
322322
* `cuda::atomic(_ref)`
323323
*

0 commit comments

Comments
 (0)