Skip to content

Commit 9c26e48

Browse files
committed
Fix CI issues: remove skipped condition from ci-success and add missing devcontainer configs
- Remove skipped condition from ci-success job to allow intentionally skipped test jobs - Add missing devcontainer configs for cuda12.0-gcc11 and cuda12.8-llvm16 to match matrix.yml
1 parent f838329 commit 9c26e48

File tree

3 files changed

+84
-1
lines changed

3 files changed

+84
-1
lines changed
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
{
2+
"shutdownAction": "stopContainer",
3+
"image": "rapidsai/devcontainers:25.08-cpp-gcc11-cuda12.0-ubuntu22.04",
4+
"hostRequirements": {
5+
"gpu": true
6+
},
7+
"initializeCommand": [
8+
"/bin/bash",
9+
"-c",
10+
"mkdir -m 0755 -p ${localWorkspaceFolder}/.{aws,cache,config}"
11+
],
12+
"containerEnv": {
13+
"SCCACHE_REGION": "us-east-2",
14+
"SCCACHE_BUCKET": "rapids-sccache-devs",
15+
"AWS_ROLE_ARN": "arn:aws:iam::279114543810:role/nv-gha-token-sccache-devs",
16+
"HISTFILE": "${containerWorkspaceFolder}/.cache/._bash_history",
17+
"DEVCONTAINER_NAME": "cuda12.0-gcc11",
18+
"CUCO_CUDA_VERSION": "12.0",
19+
"CUCO_HOST_COMPILER": "gcc",
20+
"CUCO_HOST_COMPILER_VERSION": "11"
21+
},
22+
"workspaceFolder": "/home/coder/${localWorkspaceFolderBasename}",
23+
"workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/${localWorkspaceFolderBasename},type=bind,consistency=consistent",
24+
"mounts": [
25+
"source=${localWorkspaceFolder}/.aws,target=/home/coder/.aws,type=bind,consistency=consistent",
26+
"source=${localWorkspaceFolder}/.cache,target=/home/coder/.cache,type=bind,consistency=consistent",
27+
"source=${localWorkspaceFolder}/.config,target=/home/coder/.config,type=bind,consistency=consistent"
28+
],
29+
"customizations": {
30+
"vscode": {
31+
"extensions": [
32+
"llvm-vs-code-extensions.vscode-clangd"
33+
],
34+
"settings": {
35+
"clangd.arguments": [
36+
"--compile-commands-dir=${workspaceFolder}/build/latest"
37+
]
38+
}
39+
}
40+
},
41+
"name": "cuda12.0-gcc11"
42+
}
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
{
2+
"shutdownAction": "stopContainer",
3+
"image": "rapidsai/devcontainers:25.08-cpp-llvm16-cuda12.8-ubuntu22.04",
4+
"hostRequirements": {
5+
"gpu": true
6+
},
7+
"initializeCommand": [
8+
"/bin/bash",
9+
"-c",
10+
"mkdir -m 0755 -p ${localWorkspaceFolder}/.{aws,cache,config}"
11+
],
12+
"containerEnv": {
13+
"SCCACHE_REGION": "us-east-2",
14+
"SCCACHE_BUCKET": "rapids-sccache-devs",
15+
"AWS_ROLE_ARN": "arn:aws:iam::279114543810:role/nv-gha-token-sccache-devs",
16+
"HISTFILE": "${containerWorkspaceFolder}/.cache/._bash_history",
17+
"DEVCONTAINER_NAME": "cuda12.8-llvm16",
18+
"CUCO_CUDA_VERSION": "12.8",
19+
"CUCO_HOST_COMPILER": "llvm",
20+
"CUCO_HOST_COMPILER_VERSION": "16"
21+
},
22+
"workspaceFolder": "/home/coder/${localWorkspaceFolderBasename}",
23+
"workspaceMount": "source=${localWorkspaceFolder},target=/home/coder/${localWorkspaceFolderBasename},type=bind,consistency=consistent",
24+
"mounts": [
25+
"source=${localWorkspaceFolder}/.aws,target=/home/coder/.aws,type=bind,consistency=consistent",
26+
"source=${localWorkspaceFolder}/.cache,target=/home/coder/.cache,type=bind,consistency=consistent",
27+
"source=${localWorkspaceFolder}/.config,target=/home/coder/.config,type=bind,consistency=consistent"
28+
],
29+
"customizations": {
30+
"vscode": {
31+
"extensions": [
32+
"llvm-vs-code-extensions.vscode-clangd"
33+
],
34+
"settings": {
35+
"clangd.arguments": [
36+
"--compile-commands-dir=${workspaceFolder}/build/latest"
37+
]
38+
}
39+
}
40+
},
41+
"name": "cuda12.8-llvm16"
42+
}

.github/workflows/pr.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,5 @@ jobs:
101101
${{
102102
contains(needs.*.result, 'failure')
103103
|| contains(needs.*.result, 'cancelled')
104-
|| contains(needs.*.result, 'skipped')
105104
}}
106105
run: exit 1

0 commit comments

Comments
 (0)