Skip to content

Commit 615dcad

Browse files
Apply suggestions from code review
Co-authored-by: Yunsong Wang <[email protected]>
1 parent fbbee7d commit 615dcad

File tree

4 files changed

+1
-30
lines changed

4 files changed

+1
-30
lines changed

include/cuco/detail/open_addressing/open_addressing_impl.cuh

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1130,17 +1130,6 @@ class open_addressing_impl {
11301130
counter.reset(stream.get());
11311131

11321132
int32_t constexpr block_size = cuco::detail::default_block_size();
1133-
// int32_t grid_size =
1134-
// detail::max_occupancy_grid_size(block_size,
1135-
// detail::retrieve<IsOuter,
1136-
// block_size,
1137-
// InputProbeIt,
1138-
// OutputProbeIt,
1139-
// OutputMatchIt,
1140-
// typename counter_type::value_type,
1141-
// Ref>);
1142-
// grid_size *= 64; // oversubscription factor
1143-
// // TODO shrink grid if n is very small
11441133

11451134
auto constexpr grid_stride = 1;
11461135
auto const grid_size = cuco::detail::grid_size(n, cg_size, grid_stride, block_size);

include/cuco/detail/open_addressing/open_addressing_ref_impl.cuh

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1253,22 +1253,6 @@ class open_addressing_ref_impl {
12531253
? sentinel_writers.size()
12541254
: active_flushing_tile.size() - sentinel_writers.size();
12551255
}
1256-
// if (finished and not found_any_match) {
1257-
// #if defined(CUCO_HAS_CG_INVOKE_ONE)
1258-
// cg::invoke_one(probing_tile, [&]() {
1259-
// probe_buffers[flushing_tile_id][num_matches] = probe;
1260-
// probe_buffers[flushing_tile_id][num_matches] =
1261-
// this->empty_slot_sentinel();
1262-
// });
1263-
// #else
1264-
// if (probing_tile.thread_rank() == 0) {
1265-
// probe_buffers[flushing_tile_id][num_matches] = probe;
1266-
// probe_buffers[flushing_tile_id][num_matches] =
1267-
// this->empty_slot_sentinel();
1268-
// }
1269-
// #endif
1270-
// num_matches++; // not really a match but a sentinel in the buffer
1271-
// }
12721256
}
12731257

12741258
// if the buffer has not enough empty slots for the next iteration

include/cuco/detail/static_multiset/static_multiset.inl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,6 @@ void static_multiset<Key, Extent, Scope, KeyEqual, ProbingScheme, Allocator, Sto
277277
impl_->find_async(first, last, output_begin, ref(op::find), stream);
278278
}
279279

280-
// TODO docs
281280
template <class Key,
282281
class Extent,
283282
cuda::thread_scope Scope,
@@ -298,7 +297,6 @@ static_multiset<Key, Extent, Scope, KeyEqual, ProbingScheme, Allocator, Storage>
298297
first, last, output_probe, output_match, this->ref(op::retrieve), stream);
299298
}
300299

301-
// TODO docs
302300
template <class Key,
303301
class Extent,
304302
cuda::thread_scope Scope,

include/cuco/detail/static_multiset/static_multiset_ref.inl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -554,7 +554,7 @@ class operator_impl<
554554
* slot contents to `output_match`, respectively. The output order is unspecified.
555555
*
556556
* Behavior is undefined if the size of the output range exceeds the number of retrieved slots.
557-
* Use `count()` to determine the size of the output range.
557+
* Use `count_outer()` to determine the size of the output range.
558558
*
559559
* If a key `k` has no matches in the container, then `{key, empty_slot_sentinel}` will be added
560560
* to the output sequence.

0 commit comments

Comments
 (0)