Skip to content

Commit 97ae80f

Browse files
committed
Jupyter: Create the log directory on container start instead of in the Dockerfile.
1 parent fb4fad2 commit 97ae80f

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

brev/jupyter-start.bash

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,6 @@
22

33
/accelerated-computing-hub/brev/jupyter-generate-settings.bash
44

5-
exec python -m jupyter lab --NotebookApp.default_url="${1}"
5+
mkdir -p /accelerated-computing-hub/logs
6+
7+
exec python -m jupyter lab --ServerApp.default_url="${1}"

tutorials/accelerated-python/brev/dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@ RUN `# Install Python packages` \
2929
&& mkdir -p ~/.ipython/profile_default/startup \
3030
&& ln -fs /accelerated-computing-hub/brev/ipython-startup-add-cwd-to-path.py ~/.ipython/profile_default/startup/00-add-cwd-to-path.py \
3131
&& python -m jupyter labextension disable "@jupyterlab/apputils-extension:announcements" \
32-
&& `# Create logs directory` \
33-
&& mkdir -p /accelerated-computing-hub/logs \
3432
&& `# Create an isolated Python venv with cuDF and register it as a Jupyter kernel` \
3533
&& python -m venv ${CUDF_VENV} \
3634
&& ${CUDF_VENV}/bin/python -m pip install --upgrade pip \

tutorials/cuda-cpp/brev/dockerfile

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ RUN `# Install Python packages` \
2727
&& ln -fs /accelerated-computing-hub/brev/jupyter-server-config.py ~/.jupyter/jupyter_server_config.py \
2828
&& mkdir -p ~/.ipython/profile_default/startup \
2929
&& ln -fs /accelerated-computing-hub/brev/ipython-startup-add-cwd-to-path.py ~/.ipython/profile_default/startup/00-add-cwd-to-path.py \
30-
&& python -m jupyter labextension disable "@jupyterlab/apputils-extension:announcements" \
31-
&& `# Create logs directory` \
32-
&& mkdir -p /accelerated-computing-hub/logs
30+
&& python -m jupyter labextension disable "@jupyterlab/apputils-extension:announcements"
3331

3432
ENTRYPOINT ["/accelerated-computing-hub/brev/jupyter-start.bash"]

tutorials/stdpar/brev/docker-recipe.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,6 @@
107107

108108
# Silence JupyterLab announcements
109109
'python -m jupyter labextension disable "@jupyterlab/apputils-extension:announcements"',
110-
111-
# Create logs directory
112-
'mkdir -p /accelerated-computing-hub/logs',
113110
])
114111

115112
Stage0 += raw(docker='ARG GIT_BRANCH_NAME')

0 commit comments

Comments
 (0)