Skip to content

Commit 347fdf8

Browse files
committed
Docker Compose: Revert extends modularization because Brev doesn't support it.
1 parent ba97ce7 commit 347fdf8

File tree

2 files changed

+53
-65
lines changed

2 files changed

+53
-65
lines changed

brev/docker-compose-base.yml

Lines changed: 0 additions & 58 deletions
This file was deleted.

tutorials/accelerated-python/brev/docker-compose.yml

Lines changed: 53 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ x-config:
66
# Thus on Brev, ../.. resolves to /home, and we need to add accelerated-computing-hub/ to get
77
# to the Git repository.
88
ach-volume: &ach-volume ../..${BREV_ENV_ID:+/ubuntu/accelerated-computing-hub}:/accelerated-computing-hub
9-
docker-compose-base: &docker-compose-base https://github.com/NVIDIA/accelerated-computing-hub.git#brev-reorg:brev/docker-compose-base.yml
109
dockerfile: &dockerfile tutorials/accelerated-python/brev/dockerfile
1110
image: &image ghcr.io/nvidia/accelerated-python-tutorial:brev-reorg-latest
1211
working-dir: &working-dir /accelerated-computing-hub/tutorials/accelerated-python/notebooks
@@ -16,22 +15,69 @@ services:
1615
build:
1716
context: ../../..
1817
dockerfile: *dockerfile
18+
args:
19+
GIT_BRANCH_NAME: ${GIT_BRANCH_NAME:-HEAD}
1920
image: *image
21+
pull_policy: missing
2022
volumes:
2123
- *ach-volume
24+
environment:
25+
- BREV_ENV_ID
26+
user: root
2227
working_dir: *working-dir
28+
command: ["/update-git-branch.bash"]
29+
restart: "no"
2330
jupyter:
24-
extends:
25-
file: *docker-compose-base
26-
service: jupyter
2731
image: *image
32+
depends_on:
33+
base:
34+
condition: service_completed_successfully
35+
privileged: true
36+
ulimits:
37+
memlock: -1
38+
stack: 67108864
39+
shm_size: 1g
40+
deploy:
41+
resources:
42+
reservations:
43+
devices:
44+
- driver: nvidia
45+
count: all
46+
capabilities: [gpu]
47+
ports:
48+
- "0.0.0.0:8888:8888" # JupyterLab
2849
volumes:
2950
- *ach-volume
51+
environment:
52+
- BREV_ENV_ID
53+
user: root
3054
working_dir: *working-dir
55+
restart: "unless-stopped"
3156
nsight:
32-
extends:
33-
file: *docker-compose-base
34-
service: nsight
57+
image: nvcr.io/nvidia/devtools/nsight-streamer-nsys:2025.3.1
58+
depends_on:
59+
base:
60+
condition: service_completed_successfully
61+
pull_policy: missing
62+
ulimits:
63+
memlock: -1
64+
stack: 67108864
65+
shm_size: 1g
66+
deploy:
67+
resources:
68+
reservations:
69+
devices:
70+
- driver: nvidia
71+
count: all
72+
capabilities: [gpu]
73+
ports:
74+
- "0.0.0.0:8080:8080" # HTTP
75+
- "0.0.0.0:3478:3478" # TURN
3576
volumes:
3677
- *ach-volume
78+
environment:
79+
- BREV_ENV_ID
80+
user: root
3781
working_dir: *working-dir
82+
entrypoint: ["/accelerated-computing-hub/brev/nsight-start.bash"]
83+
restart: "unless-stopped"

0 commit comments

Comments
 (0)