Skip to content

Conversation

@liji-nv
Copy link
Collaborator

@liji-nv liji-nv commented Nov 20, 2025

Summary by CodeRabbit

  • Chores
    • Updated external dependency to the latest version.
    • Added build configuration support for latest GPU architectures.

✏️ Tip: You can customize this high-level summary in your review settings.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@liji-nv liji-nv requested a review from a team as a code owner November 20, 2025 08:21
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 20, 2025

📝 Walkthrough

Walkthrough

Updates the cutlass submodule pointer to a new revision and adds conditional preprocessor definitions to enable GDC (GPU Dynamic Code) support for Hopper and Blackwell GPU architectures in cutlass kernel compilation.

Changes

Cohort / File(s) Summary
Submodule Update
3rdparty/cutlass
Submodule revision updated to latest commit; no functional code changes
CUTLASS Kernel Configuration
cpp/tensorrt_llm/kernels/cutlass_kernels/CMakeLists.txt
Added conditional compile options defining CUTLASS_ENABLE_GDC_FOR_SM90=1 for Hopper (SM90) and CUTLASS_ENABLE_GDC_FOR_SM100=1 for Blackwell (SM100/SM103/SM120/SM121) architectures

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Submodule pointer change is trivial validation
  • CMakeLists.txt additions are straightforward conditional flag insertions with clear architecture mapping

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning PR description lacks essential information. The Description and Test Coverage sections are empty, and the PR checklist items are unchecked or incomplete. Please fill in the Description section explaining what changes were made and why, provide Test Coverage details, and verify all applicable PR checklist items are addressed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required format with NVBugs ID and [fix] type, and clearly indicates the change is about correcting Cutlass with PDL support, which aligns with the CMakeLists.txt changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@liji-nv
Copy link
Collaborator Author

liji-nv commented Nov 20, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25182 [ run ] triggered by Bot. Commit: d203553

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25182 [ run ] completed with state FAILURE. Commit: d203553
/LLM/release-1.1/L0_MergeRequest_PR pipeline #508 completed with status: 'FAILURE'

@liji-nv liji-nv force-pushed the dev-liji-enable-cutlass-pdl branch from d203553 to 901ad38 Compare November 20, 2025 09:59
@liji-nv
Copy link
Collaborator Author

liji-nv commented Nov 20, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25190 [ run ] triggered by Bot. Commit: 901ad38

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25190 [ run ] completed with state FAILURE. Commit: 901ad38
/LLM/release-1.1/L0_MergeRequest_PR pipeline #510 completed with status: 'FAILURE'

@liji-nv liji-nv force-pushed the dev-liji-enable-cutlass-pdl branch from 901ad38 to af6de8c Compare November 20, 2025 11:43
@liji-nv
Copy link
Collaborator Author

liji-nv commented Nov 20, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25203 [ run ] triggered by Bot. Commit: af6de8c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25203 [ run ] completed with state SUCCESS. Commit: af6de8c
/LLM/release-1.1/L0_MergeRequest_PR pipeline #511 completed with status: 'FAILURE'

@liji-nv
Copy link
Collaborator Author

liji-nv commented Nov 21, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25289 [ run ] triggered by Bot. Commit: af6de8c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25289 [ run ] completed with state SUCCESS. Commit: af6de8c
/LLM/release-1.1/L0_MergeRequest_PR pipeline #515 completed with status: 'FAILURE'

@liji-nv
Copy link
Collaborator Author

liji-nv commented Nov 21, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25299 [ run ] triggered by Bot. Commit: af6de8c

@liji-nv
Copy link
Collaborator Author

liji-nv commented Nov 21, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25300 [ run ] triggered by Bot. Commit: af6de8c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25299 [ run ] completed with state ABORTED. Commit: af6de8c
LLM/release-1.1/L0_MergeRequest_PR #516 (Blue Ocean) completed with status: ABORTED

@liji-nv
Copy link
Collaborator Author

liji-nv commented Nov 21, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25300 [ run ] completed with state SUCCESS. Commit: af6de8c
/LLM/release-1.1/L0_MergeRequest_PR pipeline #517 completed with status: 'FAILURE'

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25310 [ run ] triggered by Bot. Commit: fa7abd5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25310 [ run ] completed with state FAILURE. Commit: fa7abd5
/LLM/release-1.1/L0_MergeRequest_PR pipeline #518 completed with status: 'FAILURE'

@liji-nv
Copy link
Collaborator Author

liji-nv commented Nov 21, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25325 [ run ] triggered by Bot. Commit: fa7abd5

@liji-nv liji-nv enabled auto-merge (squash) November 21, 2025 14:56
@tensorrt-cicd
Copy link
Collaborator

PR_Github #25325 [ run ] completed with state FAILURE. Commit: fa7abd5
/LLM/release-1.1/L0_MergeRequest_PR pipeline #521 completed with status: 'FAILURE'

@liji-nv
Copy link
Collaborator Author

liji-nv commented Nov 22, 2025

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25425 [ run ] triggered by Bot. Commit: fa7abd5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25425 [ run ] completed with state SUCCESS. Commit: fa7abd5
/LLM/release-1.1/L0_MergeRequest_PR pipeline #526 completed with status: 'SUCCESS'
Pipeline passed with automatic retried tests. Check the rerun report for details.

@liji-nv liji-nv merged commit 0339255 into NVIDIA:release/1.1 Nov 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants