Skip to content

Conversation

@chenfeiz0326
Copy link
Collaborator

@chenfeiz0326 chenfeiz0326 commented Oct 30, 2025

Summary by CodeRabbit

  • Chores
    • Add DSR1 FP4 multinode perf cases.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@chenfeiz0326 chenfeiz0326 requested review from a team as code owners October 30, 2025 14:54
@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Post-Merge-1"

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 30, 2025

📝 Walkthrough

Walkthrough

Added two runtime logging statements to jenkins/L0_Test.groovy that print the contents of scriptContent and scriptExec variables before they are written to local and remote locations, respectively.

Changes

Cohort / File(s) Summary
Logging additions
jenkins/L0_Test.groovy
Added two runtime log statements that output scriptContent and scriptExec before writing to local and remote destinations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (3 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ⚠️ Warning The pull request description is largely incomplete and does not follow the required template structure. The PR title is a placeholder ("tmp"), the Description section is entirely empty with only the template comment remaining, the Test Coverage section contains no actual test information, and the PR Checklist items are not properly addressed despite being mostly unchecked. While the author checked one checkbox at the end, none of the critical descriptive sections have been filled out. The template clearly requires formatted sections for title, description explaining the changes, and test coverage information, all of which are absent from this submission. The author must provide a complete PR description by: filling in the PR title using the required format (e.g., [JIRA-1234][chore] Add logging to jenkins script), adding a clear explanation in the Description section of what changes are being made and why, listing the relevant tests in the Test Coverage section that validate the changes, and properly reviewing and checking the relevant items in the PR Checklist. The current submission appears to be the empty template without substantive content.
Title check ⚠️ Warning The pull request title describes adding multi-node performance tests to CI, but the actual changes only add logging statements to an existing test file with no functional behavior changes. Update the title to reflect the actual changes, such as 'Add runtime logging to L0_Test.groovy for script content debugging' or similar, which accurately describes the logging additions made.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chenfeiz0326 chenfeiz0326 changed the title tmp [TRTLLM-8825][feat] Support Pytest Perf Results uploading to Database Oct 30, 2025
@chenfeiz0326 chenfeiz0326 changed the title [TRTLLM-8825][feat] Support Pytest Perf Results uploading to Database [TRTLLM-9000][feat] tmp Oct 30, 2025
@tensorrt-cicd
Copy link
Collaborator

PR_Github #23060 [ run ] triggered by Bot. Commit: d31d4b1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23060 [ run ] completed with state SUCCESS. Commit: d31d4b1
/LLM/main/L0_MergeRequest_PR pipeline #17387 (Partly Tested) completed with status: 'SUCCESS'

@chenfeiz0326 chenfeiz0326 force-pushed the chenfeiz/support-multi-node-perf-test branch from d31d4b1 to c746c07 Compare November 5, 2025 07:48
@chenfeiz0326 chenfeiz0326 changed the title [TRTLLM-9000][feat] tmp [TRTLLM-9000][feat] Add multi-node Perf Tests into CI Nov 5, 2025
@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Perf-Sanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23614 [ run ] triggered by Bot. Commit: 2d9ecc1

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23614 [ run ] completed with state FAILURE. Commit: 2d9ecc1
/LLM/main/L0_MergeRequest_PR pipeline #17768 (Partly Tested) completed with status: 'FAILURE'

@chenfeiz0326 chenfeiz0326 force-pushed the chenfeiz/support-multi-node-perf-test branch from 2d9ecc1 to 6cb155c Compare November 5, 2025 10:08
@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Perf-Sanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23637 [ run ] triggered by Bot. Commit: 6cb155c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23637 [ run ] completed with state SUCCESS. Commit: 6cb155c
/LLM/main/L0_MergeRequest_PR pipeline #17784 (Partly Tested) completed with status: 'FAILURE'

@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Perf-Sanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23699 [ run ] triggered by Bot. Commit: c0943af

@tensorrt-cicd
Copy link
Collaborator

PR_Github #23699 [ run ] completed with state FAILURE. Commit: c0943af
/LLM/main/L0_MergeRequest_PR pipeline #17833 (Partly Tested) completed with status: 'FAILURE'

@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Perf-Sanity-Post-Merge-1"

@chenfeiz0326 chenfeiz0326 force-pushed the chenfeiz/support-multi-node-perf-test branch from f140b9c to 5809fc7 Compare November 11, 2025 07:36
@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Perf-Sanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #24134 [ run ] triggered by Bot. Commit: 853b08d

@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25953 [ run ] triggered by Bot. Commit: 016fd25

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25953 [ run ] completed with state FAILURE. Commit: 016fd25
/LLM/main/L0_MergeRequest_PR pipeline #19683 (Partly Tested) completed with status: 'FAILURE'

@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25972 [ run ] triggered by Bot. Commit: 3057f8c

@tensorrt-cicd
Copy link
Collaborator

PR_Github #25972 [ run ] completed with state SUCCESS. Commit: 3057f8c
/LLM/main/L0_MergeRequest_PR pipeline #19697 (Partly Tested) completed with status: 'FAILURE'

@chenfeiz0326 chenfeiz0326 force-pushed the chenfeiz/support-multi-node-perf-test branch from 3057f8c to da0d471 Compare November 27, 2025 08:53
@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-PerfSanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26007 [ run ] triggered by Bot. Commit: da0d471

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26007 [ run ] completed with state SUCCESS. Commit: da0d471
/LLM/main/L0_MergeRequest_PR pipeline #19730 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Chenfei Zhang <[email protected]>
Signed-off-by: Chenfei Zhang <[email protected]>
Signed-off-by: Chenfei Zhang <[email protected]>
@chenfeiz0326 chenfeiz0326 force-pushed the chenfeiz/support-multi-node-perf-test branch from da0d471 to 0235dde Compare November 27, 2025 11:11
@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Perf-Sanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26028 [ run ] triggered by Bot. Commit: 0235dde

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26028 [ run ] completed with state SUCCESS. Commit: 0235dde
/LLM/main/L0_MergeRequest_PR pipeline #19754 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Chenfei Zhang <[email protected]>
@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "GB200-8_GPUs-2_Nodes-PyTorch-Perf-Sanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26042 [ run ] triggered by Bot. Commit: d0d6f59

// Perf sanity post merge test
// Disable perf stages due to https://nvbugs/5643646
// "DGX_B200-4_GPUs-PyTorch-Perf-Sanity-Post-Merge-1": ["b200-x4", "perf_sanity_l0_dgx_b200", 1, 1, 4],
"DGX_B200-4_GPUs-PyTorch-Perf-Sanity-Post-Merge-1": ["b200-x4", "perf_sanity_l0_dgx_b200", 1, 2, 4],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check if the test splitting really happens? I vaguely remember that the test splitting doesn't work for the existing Perf test stages.

CC @EmmaQiaoCh

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26042 [ run ] completed with state SUCCESS. Commit: d0d6f59
/LLM/main/L0_MergeRequest_PR pipeline #19766 (Partly Tested) completed with status: 'SUCCESS'

Signed-off-by: Chenfei Zhang <[email protected]>
@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Perf-Sanity-Post-Merge-1"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26076 [ run ] triggered by Bot. Commit: 64907c5

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26076 [ run ] completed with state SUCCESS. Commit: 64907c5
/LLM/main/L0_MergeRequest_PR pipeline #19800 (Partly Tested) completed with status: 'FAILURE'

Signed-off-by: Chenfei Zhang <[email protected]>
Signed-off-by: Chenfei Zhang <[email protected]>
@chenfeiz0326
Copy link
Collaborator Author

/bot run --stage-list "DGX_B200-4_GPUs-PyTorch-Perf-Sanity-Post-Merge-1,DGX_B200-4_GPUs-PyTorch-Perf-Sanity-Post-Merge-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #26094 [ run ] triggered by Bot. Commit: e448781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants