Skip to content

Conversation

@pcastonguay
Copy link
Collaborator

pef: Removing initializing ptuning buffers to zero

Description

Currently, we were initializing the ptuning embedding table for all batch slots to zero at every iteration, which was costly and unnecessary. The ptuning embedding table will be filled with the request ptuning embedding table later in the fill function.

Test Coverage

We already have a Triton test that covers ptuning. I will trigger and ensure it still passes.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]

Launch build/test pipelines. All previously running jobs will be killed.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-[Post-Merge]-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@pcastonguay
Copy link
Collaborator Author

/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7528 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7528 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5460 (Partly Tested) completed with status: 'SUCCESS'

@pcastonguay
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7554 [ run ] triggered by Bot

Copy link
Collaborator

@achartier achartier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7554 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5482 completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the rm_ptuning_set_zero branch from 269408a to 2645836 Compare June 4, 2025 20:27
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7568 [ run ] triggered by Bot

@pcastonguay pcastonguay force-pushed the rm_ptuning_set_zero branch from 2645836 to 75d9e15 Compare June 5, 2025 12:56
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7734 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7734 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5605 completed with status: 'FAILURE'

@pcastonguay pcastonguay changed the title pef: Removing initializing ptuning buffers to zero perf: Removing initializing ptuning buffers to zero Jun 6, 2025
@pcastonguay pcastonguay force-pushed the rm_ptuning_set_zero branch from 75d9e15 to 1f3a4ae Compare June 6, 2025 00:45
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7800 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7800 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5649 completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the rm_ptuning_set_zero branch from 1f3a4ae to d1dd9e5 Compare June 6, 2025 15:24
@pcastonguay
Copy link
Collaborator Author

/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7927 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #7927 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #5732 (Partly Tested) completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the rm_ptuning_set_zero branch from d1dd9e5 to f6890c0 Compare June 8, 2025 22:36
@pcastonguay
Copy link
Collaborator Author

/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2"

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8045 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8045 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5831 (Partly Tested) completed with status: 'SUCCESS'

@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8059 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8059 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5843 completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the rm_ptuning_set_zero branch from f6890c0 to bfedb95 Compare June 9, 2025 12:42
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8131 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8131 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5895 completed with status: 'FAILURE'

@pcastonguay pcastonguay force-pushed the rm_ptuning_set_zero branch from bfedb95 to 326ea03 Compare June 9, 2025 22:04
@pcastonguay
Copy link
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8164 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #8164 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #5915 completed with status: 'SUCCESS'

@pcastonguay pcastonguay merged commit 87c56ab into NVIDIA:main Jun 10, 2025
3 checks passed
anand-nv pushed a commit to anand-nv/TensorRT-LLM that referenced this pull request Aug 28, 2025
Signed-off-by: Viacheslav Klimkov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants