-
Notifications
You must be signed in to change notification settings - Fork 1.9k
perf: Removing initializing ptuning buffers to zero #4915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2" |
|
PR_Github #7528 [ run ] triggered by Bot |
|
PR_Github #7528 [ run ] completed with state |
|
/bot run |
|
PR_Github #7554 [ run ] triggered by Bot |
achartier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
PR_Github #7554 [ run ] completed with state |
269408a to
2645836
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #7568 [ run ] triggered by Bot |
2645836 to
75d9e15
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #7734 [ run ] triggered by Bot |
|
PR_Github #7734 [ run ] completed with state |
75d9e15 to
1f3a4ae
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #7800 [ run ] triggered by Bot |
|
PR_Github #7800 [ run ] completed with state |
1f3a4ae to
d1dd9e5
Compare
|
/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2" |
|
PR_Github #7927 [ run ] triggered by Bot |
|
PR_Github #7927 [ run ] completed with state |
d1dd9e5 to
f6890c0
Compare
|
/bot run --stage-list "A100X-Triton-Python-[Post-Merge]-1, A100X-Triton-Python-[Post-Merge]-2" |
|
PR_Github #8045 [ run ] triggered by Bot |
|
PR_Github #8045 [ run ] completed with state |
|
/bot run --disable-fail-fast |
|
PR_Github #8059 [ run ] triggered by Bot |
|
PR_Github #8059 [ run ] completed with state |
f6890c0 to
bfedb95
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #8131 [ run ] triggered by Bot |
|
PR_Github #8131 [ run ] completed with state |
Signed-off-by: Patrice Castonguay <[email protected]>
bfedb95 to
326ea03
Compare
|
/bot run --disable-fail-fast |
|
PR_Github #8164 [ run ] triggered by Bot |
|
PR_Github #8164 [ run ] completed with state |
Signed-off-by: Viacheslav Klimkov <[email protected]>
pef: Removing initializing ptuning buffers to zero
Description
Currently, we were initializing the ptuning embedding table for all batch slots to zero at every iteration, which was costly and unnecessary. The ptuning embedding table will be filled with the request ptuning embedding table later in the
fillfunction.Test Coverage
We already have a Triton test that covers ptuning. I will trigger and ensure it still passes.
GitHub Bot Help
/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...Provide a user friendly way for developers to interact with a Jenkins server.
Run
/bot [-h|--help]to print this help message.See details below for each supported subcommand.
run [--disable-fail-fast --skip-test --stage-list "A10-1, xxx" --gpu-type "A30, H100_PCIe" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-[Post-Merge]-1, xxx"]Launch build/test pipelines. All previously running jobs will be killed.
--disable-fail-fast(OPTIONAL) : Disable fail fast on build/tests/infra failures.--skip-test(OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.--stage-list "A10-1, xxx"(OPTIONAL) : Only run the specified test stages. Examples: "A10-1, xxx". Note: Does NOT update GitHub check status.--gpu-type "A30, H100_PCIe"(OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.--only-multi-gpu-test(OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.--disable-multi-gpu-test(OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.--add-multi-gpu-test(OPTIONAL) : Force run the multi-GPU tests. Will also run L0 pre-merge pipeline.--post-merge(OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.--extra-stage "H100_PCIe-[Post-Merge]-1, xxx"(OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-[Post-Merge]-1, xxx".kill
killKill all running builds associated with pull request.
skip
skip --comment COMMENTSkip testing for latest commit on pull request.
--comment "Reason for skipping build/test"is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.reuse-pipeline
reuse-pipelineReuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.