Merge branch 'main' of github.com:NVIDIA/TensorRT-Incubator into dev-yizhuoz-shape-input

Author: yizhuoz004

mlir-tensorrt/CONTRIBUTING.md

@@ -9,6 +9,35 @@ described here: https://llvm.org/docs/CodingStandards.html
 
 Python files are formatted using the [`black` formatter](https://black.readthedocs.io/en/stable/).
 
+## Development Environment
+
+This project provides a pre-configured CUDA 12.5 development environment using [Dev Containers](https://containers.dev/). We offer configurations for both `ubuntu` and `rockylinux8`, located in the `.devcontainer` directory.
+
+### VS Code (Recommended)
+1. Install the [Dev Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers).
+2. Open the project in VS Code.
+3. When prompted, click "Reopen in Container" and select your preferred OS configuration.
+
+VS Code will automatically build the container and connect to the development environment.
+
+### Dev Containers CLI
+If you are not using VS Code, you can manage the environment with the [Dev Containers CLI](https://github.com/devcontainers/cli).
+
+1.  Install the CLI.
+2.  Choose one of the available configurations from the `.devcontainer` directory (e.g., `cuda12.5-ubuntu-llvm17`).
+3.  From the project root, build and start the container by running the `up` command. Replace `<config-name>` with your chosen configuration.
+    ```bash
+    devcontainer up --workspace-folder . --config .devcontainer/<config-name>/devcontainer.json
+    ```
+    For example:
+    ```bash
+    devcontainer up --workspace-folder . --config .devcontainer/cuda12.5-ubuntu-llvm17/devcontainer.json
+    ```
+4.  To open a shell inside the running container, use the `exec` command:
+    ```bash
+    devcontainer exec --workspace-folder . --config .devcontainer/<config-name>/devcontainer.json /bin/bash
+    ```
+
 ## How to Submit a PR
 
 - Fork the repo on GitHub

mlir-tensorrt/Version.cmake

@@ -1,5 +1,5 @@
 set(MLIR_TENSORRT_VERSION_MAJOR "0")
 set(MLIR_TENSORRT_VERSION_MINOR "1")
-set(MLIR_TENSORRT_VERSION_PATCH "42")
+set(MLIR_TENSORRT_VERSION_PATCH "43")
 set(MLIR_TENSORRT_VERSION
   "${MLIR_TENSORRT_VERSION_MAJOR}.${MLIR_TENSORRT_VERSION_MINOR}.${MLIR_TENSORRT_VERSION_PATCH}")

tripy/nvtripy/frontend/ops/slice.py

@@ -208,11 +208,19 @@ def get_min(a, b):
                     else minimum(cast_to_dim_size(a), cast_to_dim_size(b))
                 )
 
+            def get_max(a, b):
+                return (
+                    max(a, b)
+                    if isinstance(a, int) and isinstance(b, int)
+                    else maximum(cast_to_dim_size(a), cast_to_dim_size(b))
+                )
+
             if slice_idx.start is not None:
                 start = to_positive_idx(slice_idx.start)
                 # If `start` is past the end, clamp it - if we're going backwards, we need to clamp it to a valid value;
                 # otherwise, we can clamp it out of bounds (which will yield an empty tensor):
                 start = get_min(start, select(step >= 0, dim_size, dim_size - 1))
+                start = get_max(start, 0)  # if the adjusted start is still negative, clamp it to 0
             else:
                 start = default_start
 

tripy/tests/integration/test_slice.py

@@ -69,6 +69,7 @@ class TestSliceOp:
             ((2, 3, 4), lambda t: t[None]),
             ((2, 3, 4), lambda t: t[None, 1:2, :, None]),
             ((2, 3, 4), lambda t: t[..., None, 0, None]),
+            ((1, 2), lambda t: t[:, -4:]),  # negative start greater than dimension size
         ],
     )
     def test_slice(self, use_constant, shape, slice_func, eager_or_compiled):

tripy/tests/test_examples.py

@@ -93,8 +93,9 @@ def __str__(self):
 
 
 def test_all_examples_tested():
-    num_dirs = len([d for d in os.listdir(EXAMPLES_ROOT) if os.path.isdir(os.path.join(EXAMPLES_ROOT, d))])
-    assert num_dirs == len(EXAMPLES), "Not all examples are being tested!"
+    tested_examples = set(os.path.relpath(example.path, EXAMPLES_ROOT) for example in EXAMPLES)
+    all_examples = set(d for d in os.listdir(EXAMPLES_ROOT) if os.path.isdir(os.path.join(EXAMPLES_ROOT, d)))
+    assert tested_examples == all_examples, "Not all examples are being tested!"
 
 
 # We want to test our examples with both the latest commit and public build.

tripy/tests/utils/wrappers/test_datatype_constraints.py

@@ -222,8 +222,7 @@ def test_datatype_constraints(case: DtypeConstraintCase):
             outputs = make_list(case.func(**inputs))
 
             # Some APIs do not generate Tensor outputs (e.g. `allclose`), so we don't need to evaluate those.
-            # For DimensionSizes, we don't need to check the type either (they can only be one type)
-            if not any(type(out) == tp.Tensor for out in outputs):
+            if not any(isinstance(out, tp.Tensor) for out in outputs):
                 return
 
             expected_return_types = [