Skip to content

Commit ed379cc

Browse files
committed
chore: go mod tidy
Signed-off-by: Ajay Mishra <[email protected]>
1 parent 02f7721 commit ed379cc

File tree

3 files changed

+23
-3
lines changed

3 files changed

+23
-3
lines changed

health-monitors/kubernetes-object-monitor/go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ require (
1212
google.golang.org/grpc v1.76.0
1313
google.golang.org/protobuf v1.36.10
1414
k8s.io/api v0.34.1
15+
k8s.io/apiextensions-apiserver v0.34.1
1516
k8s.io/apimachinery v0.34.1
1617
sigs.k8s.io/controller-runtime v0.22.4
1718
)
@@ -73,7 +74,6 @@ require (
7374
gopkg.in/evanphx/json-patch.v4 v4.13.0 // indirect
7475
gopkg.in/inf.v0 v0.9.1 // indirect
7576
gopkg.in/yaml.v3 v3.0.1 // indirect
76-
k8s.io/apiextensions-apiserver v0.34.1 // indirect
7777
k8s.io/client-go v0.34.1 // indirect
7878
k8s.io/klog/v2 v2.130.1 // indirect
7979
k8s.io/kube-openapi v0.0.0-20250910181357-589584f1c912 // indirect

health-monitors/kubernetes-object-monitor/pkg/controller/reconciler.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,15 +150,15 @@ func (r *ResourceReconciler) reconcilePolicy(
150150
stateKey := r.getStateKey(p, obj)
151151

152152
r.matchStatesMu.RLock()
153-
_, wasMatched := r.matchStates[stateKey]
153+
storedNodeName, wasMatched := r.matchStates[stateKey]
154154
r.matchStatesMu.RUnlock()
155155

156156
if matched && !wasMatched {
157157
return r.handleUnhealthyTransition(ctx, p, nodeName, stateKey)
158158
}
159159

160160
if !matched && wasMatched {
161-
return r.handleHealthyTransition(ctx, p, nodeName, stateKey)
161+
return r.handleHealthyTransition(ctx, p, storedNodeName, stateKey)
162162
}
163163

164164
return nil

health-monitors/kubernetes-object-monitor/pkg/controller/reconciler_test.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,26 @@ func TestReconciler_CustomResource(t *testing.T) {
328328
!event.isHealthy &&
329329
event.policy.Name == "gpu-job-failed"
330330
}, time.Second, 50*time.Millisecond)
331+
332+
setup.publisher.publishedEvents = []mockPublishedEvent{}
333+
334+
require.NoError(t, setup.k8sClient.Delete(setup.ctx, gpuJob))
335+
336+
result, err = setup.reconciler.Reconcile(setup.ctx, ctrl.Request{
337+
NamespacedName: types.NamespacedName{Name: jobName, Namespace: namespace},
338+
})
339+
assert.NoError(t, err)
340+
assert.Equal(t, ctrl.Result{}, result)
341+
342+
require.Eventually(t, func() bool {
343+
if len(setup.publisher.publishedEvents) != 1 {
344+
return false
345+
}
346+
event := setup.publisher.publishedEvents[0]
347+
return event.nodeName == nodeName &&
348+
event.isHealthy &&
349+
event.policy.Name == "gpu-job-failed"
350+
}, time.Second, 50*time.Millisecond)
331351
}
332352

333353
func TestReconciler_ColdStart(t *testing.T) {

0 commit comments

Comments
 (0)