chore: move condition change function to its own file

Author: mchmarny

janitor/pkg/controller/backoff.go

@@ -31,7 +31,7 @@ func getNextRequeueDelay(consecutiveFailures int32) time.Duration {
 		5 * time.Minute,  // Fourth+ retry (capped)
 	}
 
-	// Safely convert int32 to int for array indexing
+	// Convert int32 to int for array indexing and cap at maximum if needed
 	idx := int(consecutiveFailures)
 	if idx >= len(delays) {
 		return delays[len(delays)-1] // Cap at maximum

janitor/pkg/controller/rebootnode_controller.go

@@ -47,37 +47,6 @@ const (
 	MaxRebootRetries = 20 // 10 minutes at 30s base intervals
 )
 
-// conditionsChanged compares two sets of conditions and returns true if they differ.
-// It checks the type, status, reason, and message of each condition.
-func conditionsChanged(original, updated []metav1.Condition) bool {
-	if len(original) != len(updated) {
-		return true
-	}
-
-	// Build a map of original conditions for quick lookup
-	originalMap := make(map[string]metav1.Condition)
-	for _, cond := range original {
-		originalMap[cond.Type] = cond
-	}
-
-	// Check each updated condition against the original
-	for _, updatedCond := range updated {
-		originalCond, exists := originalMap[updatedCond.Type]
-		if !exists {
-			return true // New condition type added
-		}
-
-		// Compare the fields that matter for status updates
-		if originalCond.Status != updatedCond.Status ||
-			originalCond.Reason != updatedCond.Reason ||
-			originalCond.Message != updatedCond.Message {
-			return true
-		}
-	}
-
-	return false
-}
-
 // updateRebootNodeStatus is a helper function that handles status updates with proper error handling.
 // It delegates to the generic updateNodeActionStatus function.
 func (r *RebootNodeReconciler) updateRebootNodeStatus(

janitor/pkg/controller/status_update.go

@@ -46,6 +46,37 @@ type NodeActionSpec interface {
 	GetNodeName() string
 }
 
+// conditionsChanged compares two slices of conditions and returns true if they differ.
+// It checks for differences in Type, Status, Reason, and Message fields.
+func conditionsChanged(original, updated []metav1.Condition) bool {
+	if len(original) != len(updated) {
+		return true
+	}
+
+	// Build a map of original conditions for quick lookup
+	originalMap := make(map[string]metav1.Condition)
+	for _, cond := range original {
+		originalMap[cond.Type] = cond
+	}
+
+	// Check each updated condition against the original
+	for _, updatedCond := range updated {
+		originalCond, exists := originalMap[updatedCond.Type]
+		if !exists {
+			return true // New condition type added
+		}
+
+		// Compare the fields that matter for status updates
+		if originalCond.Status != updatedCond.Status ||
+			originalCond.Reason != updatedCond.Reason ||
+			originalCond.Message != updatedCond.Message {
+			return true
+		}
+	}
+
+	return false
+}
+
 // updateNodeActionStatus is a generic helper function that handles status updates with proper error handling.
 // It centralizes the status update logic to avoid code duplication and provides consistent handling
 // of status updates across different node action types (RebootNode, TerminateNode, etc.).