Ensure we have lint/lint-test in all go based modules (#276)

Signed-off-by: Davanum Srinivas <[email protected]>

Author: dims

.github/workflows/lint-test.yml

@@ -137,13 +137,15 @@ jobs:
           - platform-connectors
           - store-client
           - commons
+          - data-models
           - health-events-analyzer
           - fault-quarantine
           - labeler
           - metadata-collector
           - node-drainer
           - fault-remediation
           - janitor
+          - tests
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
 
@@ -162,11 +164,36 @@ jobs:
             ${{ matrix.component }}/coverage.txt
             ${{ matrix.component }}/report.xml
 
+  tilt-modules-lint-test:
+    runs-on: linux-amd64-cpu16
+    timeout-minutes: 30
+    strategy:
+      matrix:
+        component:
+          - tilt/simple-health-client
+    steps:
+      - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
+
+      - name: Setup build environment
+        uses: ./.github/actions/setup-ci-env
+
+      - name: Run lint and test
+        run: make -C ${{ matrix.component }} lint-test
+
+      - name: Upload artifacts
+        uses: ./.github/actions/upload-test-artifacts
+        with:
+          component-name: simple-health-client
+          file-paths: |
+            ${{ matrix.component }}/coverage.xml
+            ${{ matrix.component }}/coverage.txt
+            ${{ matrix.component }}/report.xml
+
   consolidated-coverage-report:
     if: github.event_name == 'pull_request' || startsWith(github.ref, 'refs/heads/pull-request/')
     runs-on: linux-amd64-cpu16
     timeout-minutes: 15
-    needs: [health-monitors-lint-test, modules-lint-test]
+    needs: [health-monitors-lint-test, modules-lint-test, tilt-modules-lint-test]
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
 
@@ -363,7 +390,7 @@ jobs:
     if: github.ref == 'refs/heads/main' && github.event_name == 'push'
     runs-on: linux-amd64-cpu16
     timeout-minutes: 15
-    needs: [health-monitors-lint-test, modules-lint-test]
+    needs: [health-monitors-lint-test, modules-lint-test, tilt-modules-lint-test]
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8  # v5.0.0
 

tests/Makefile

@@ -1,13 +1,47 @@
 # Tests Makefile
 # End-to-end test targets
 
-# Go binary
-GO := go
+# Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# =============================================================================
+# MODULE-SPECIFIC CONFIGURATION
+# =============================================================================
+
+# E2E Tests module configuration
+IS_GO_MODULE := 1
+TEST_EXTRA_FLAGS := -timeout 40m -count 1 -failfast
+
+# =============================================================================
+# INCLUDE COMMON DEFINITIONS
+# =============================================================================
+
+include ../make/common.mk
+include ../make/go.mk
+
+# =============================================================================
+# E2E-SPECIFIC TARGETS
+# =============================================================================
 
 # Default target
 .PHONY: all
 all: test
 
+.PHONY: lint-test
+lint-test: lint ## Run linting only (override go.mk comprehensive version)
+	@echo "Linting complete for $(MODULE_NAME)"
+
 # Run end-to-end tests in CI
 .PHONY: test-ci
 test-ci:
@@ -21,18 +55,27 @@ test-ci:
 	kubectl rollout status deployment/fault-quarantine -n nvsentinel --timeout=10m
 	$(MAKE) test
 
-# Run end-to-end tests
+# Run end-to-end tests (override standard test to use gotestsum with custom format)
 .PHONY: test
-test:
-	gotestsum --format standard-verbose -- -timeout 40m -count 1 -failfast ./...
+test: ## Run end-to-end tests
+	@echo "Running end-to-end tests on $(MODULE_NAME)..."
+	$(GOTESTSUM) --format standard-verbose -- $(TEST_EXTRA_FLAGS) ./... -coverprofile=coverage.txt -covermode atomic -coverpkg=github.com/nvidia/nvsentinel/$(MODULE_NAME)/...
 
-# Help target
-.PHONY: help
-help:
-	@echo "Tests Makefile - Simple end-to-end test execution"
+# =============================================================================
+# MODULE HELP
+# =============================================================================
+
+help: ## Show help for available targets
+	@echo "Tests Makefile - E2E test execution with standard linting"
+	@echo ""
+	@echo "Standard targets from go.mk:"
+	@echo "  lint-test - Lint and test Go module (vet + golangci-lint + gotestsum)"
+	@echo "  lint      - Run golangci-lint"
+	@echo "  vet       - Run go vet"
+	@echo "  test      - Run end-to-end tests with coverage"
+	@echo "  clean     - Clean build artifacts"
 	@echo ""
-	@echo "Targets:"
+	@echo "E2E-specific targets:"
 	@echo "  all       - Run test (default)"
 	@echo "  test-ci   - Run end-to-end tests in CI environment"
-	@echo "  test      - Run end-to-end tests"
 	@echo "  help      - Show this help message"