-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[DEV] Add support of fake distributed process group #2254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEV] Add support of fake distributed process group #2254
Conversation
153b6ed to
adb1742
Compare
|
/ok to test adb1742 |
| '--distrib-optim-fully-reshardable-mem-efficient requires -enable-gloo-process-groups' | ||
|
|
||
| if args.fake_process_group: | ||
| # Disable nan check for fake process group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Print a warning saying you are overriding these flags?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestions. Updated on #2280
| 'timeout': timedelta(minutes=args.distributed_timeout_minutes), | ||
| } | ||
| if args.fake_process_group: | ||
| from torch.testing._internal.distributed.fake_pg import FakeStore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Pytorch version introduced this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version check added on #2280
What does this PR do ?
PR to main #2280
Add support of fake distributed process groups with
--fake-process-group. In this case, all distributed communication operations will be skipped.Motivation derived from https://github.com/Victarry/PyTorch-Memory-Profiler
Usage
Quick startup
Set the target world size and rank to profile, and run the scripts as usual:
Other useful arguments for benchmarking without running with actual data:
--mock-datato use mocked datasets.--tokenizer-type NullTokenizer --vocab-size 32000to use mocked tokenizer.--moe-router-force-load-balancingto use force router load balancing.Memory Snapshot Dump
Add below arguments to dump pytorch memory snaptshot:
Then you could visualize the memory figure on https://docs.pytorch.org/memory_viz
## Mixtral 8x7B ##
## Qwen3-235B ##
## DeepSeek-V3 ##
Tested Features
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
[email protected]or[email protected].Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.