Skip to content

Conversation

@davidLif
Copy link
Collaborator

1- Add scheduler topology envtest
2- Bug fix: filter nodes that doesn't have the required topology labels

@davidLif davidLif enabled auto-merge (squash) August 28, 2025 15:37
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 72.50% (+1.99%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 81.01% (-0.37%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/utils.go 72.50% (+1.99%) 80 (+2) 58 (+3) 22 (-1) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin.go 91.11% (-3.76%) 45 (+6) 41 (+4) 4 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler_test.go

@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 71.25% (+0.74%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 81.01% (-0.37%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/utils.go 71.25% (+0.74%) 80 (+2) 57 (+2) 23 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin.go 91.11% (-3.76%) 45 (+6) 41 (+4) 4 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler_test.go

@davidLif davidLif force-pushed the DavidL/29102/envtest branch from 2c60b08 to c53fabc Compare August 31, 2025 10:39
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 72.50% (+0.71%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 81.01% (-0.37%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/utils.go 72.50% (+0.71%) 80 (+2) 58 (+2) 22 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin.go 91.11% (-3.76%) 45 (+6) 41 (+4) 4 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler_test.go

@davidLif davidLif force-pushed the DavidL/29102/envtest branch from c53fabc to b050f7e Compare August 31, 2025 11:12
@github-actions
Copy link

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 72.50% (+1.99%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 81.01% (-0.37%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/utils.go 72.50% (+1.99%) 80 (+2) 58 (+3) 22 (-1) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin.go 91.11% (-3.76%) 45 (+6) 41 (+4) 4 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler_test.go

davidLif and others added 4 commits September 1, 2025 11:39
2- Bug fix: filter nodes that doesn't have the required topology labels
@davidLif davidLif force-pushed the DavidL/29102/envtest branch from b050f7e to 7946777 Compare September 1, 2025 08:39
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Merging this branch changes the coverage (1 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 72.50% (+0.71%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 81.01% (-0.37%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/utils.go 72.50% (+0.71%) 80 (+2) 58 (+2) 22 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin.go 91.11% (-3.76%) 45 (+6) 41 (+4) 4 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler_test.go

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 71.25% (-0.54%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology 81.01% (-0.37%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/utils.go 71.25% (-0.54%) 80 (+2) 57 (+1) 23 (+1) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/topology/topology_plugin.go 91.11% (-3.76%) 45 (+6) 41 (+4) 4 (+2) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler_test.go

@davidLif davidLif merged commit dbc587b into main Sep 2, 2025
4 checks passed
@davidLif davidLif deleted the DavidL/29102/envtest branch September 2, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants